Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ease keeping version parity between IPFS/Libp2p packages #30

Open
tabcat opened this issue Nov 22, 2022 · 5 comments · Fixed by #36
Open

Ease keeping version parity between IPFS/Libp2p packages #30

tabcat opened this issue Nov 22, 2022 · 5 comments · Fixed by #36

Comments

@tabcat
Copy link
Member

tabcat commented Nov 22, 2022 •
edited
Loading

Sometimes there are version -> interface mismatches between installed ipfs and libp2p packages. Would be great to make keeping this parity easier.
@tabcat tabcat mentioned this issue Nov 22, 2022
Closed
3 tasks
@tabcat tabcat changed the title Find best way to keep version parity with IPFS and Libp2p packages Ease keeping version parity with IPFS and Libp2p packages Nov 22, 2022
@tabcat tabcat changed the title Ease keeping version parity with IPFS and Libp2p packages Ease keeping version parity with IPFS/Libp2p packages Nov 22, 2022
@tabcat tabcat changed the title Ease keeping version parity with IPFS/Libp2p packages Ease keeping version parity between IPFS/Libp2p packages Nov 23, 2022
@tabcat
Copy link
Member Author

tabcat commented Nov 23, 2022

Will look more later to see if there is tooling available to automatically bump dependencies to the package being bumped if they are also directly used and installed.
May also just end up having ipfs-core as a peer dependency and not directly installing the sub-dependencies that are used directly.

@tabcat
Copy link
Member Author

tabcat commented Nov 24, 2022

Removing ipfs from devDeps.
Adding ipfs-core to deps and removing packages from package.json which are also dependencies of ipfs-core.

@tabcat tabcat closed this as completed in db7d3f1 Nov 24, 2022
@tabcat
Copy link
Member Author

tabcat commented Dec 23, 2022

Will be adding depcheck to ci workflow. Still want to make it easy to use same versions of packages as ipfs-core so will write a script or separate package to handle this probably using npm ls.

@tabcat tabcat reopened this Dec 23, 2022
@tabcat
Copy link
Member Author

tabcat commented Dec 28, 2022

created https://github.com/tabcat/copy-deps for this but needs tabcat/copy-deps#6 to be closed

tabcat added a commit that referenced this issue Dec 28, 2022
@tabcat
fix: add deps directly with copy-deps
c14c1b9 
Related: #30
tabcat added a commit that referenced this issue Dec 28, 2022
@tabcat
Fix/add deps (#35)
61659d8 
* chore: install depcheck

* chore: add dep-check script

* fix: add deps directly with copy-deps

Related: #30
tabcat added a commit that referenced this issue Dec 28, 2022
@tabcat
fix: add deps #35
98a03f8 
* chore: install depcheck

* chore: add dep-check script

* fix: add deps directly with copy-deps

Related: #30
@github-actions github-actions bot mentioned this issue Dec 28, 2022
Merged
@tabcat tabcat reopened this Dec 29, 2022
@tabcat
Copy link
Member Author

tabcat commented Dec 29, 2022

Not sure why the bot closed this. Guessing it was a commit that included Related: #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(master): release 1.0.2 hldb/welo
1 participant
@tabcat