Adaptable (remove checks for is_adaptable) #1
Labels
Comments
hlindberg
pushed a commit
that referenced
this issue
Jun 14, 2013
…to-console'" This reverts commit 8d99bcb, reversing changes made to 7d6515f. This change had two unintended side effects: 1) 20900 tagmail from 'puppet agent --onetime' run as a cron job begins sending additional emails of verbose logs. 2) 20919 cron job of 'puppet agent --onetime --no-daemonize' produces additional verbose logs to both console and syslog. Issue #1 occured because the 15187 patch caused agent log level to switch to info by default. Issue #2 was due to the above log level issue, and the fact that by default a console logger was also opened for all agents, which does not get closed if --no-daemonize is specified. Reverting fixes both of these unintended logging issues by returning to the logging behavior seen in 3.1.1.
hlindberg
pushed a commit
that referenced
this issue
Oct 16, 2014
…quotes Basically, single quotes within a string need to be escaped when the string is wrapped in single quotes, thus making the overall line harder to read, breaking philosophy #1. The tooling obviously throws an error when you try to use double quotes here, but without clear guidance one just ends up in a debate. My patch is about being clearer for this edge-case, for the sake of philosophy #1 (readability). Signed-off-by: Ken Barber <ken@bob.sh>
hlindberg
pushed a commit
that referenced
this issue
Oct 16, 2014
Fixes to _config.yml for puppetdb 1.2
hlindberg
pushed a commit
that referenced
this issue
Oct 16, 2014
A few minor copy edits for Event Inspector
hlindberg
pushed a commit
that referenced
this issue
Mar 11, 2016
The TypeAsserter methods takes a `subject` parameter that explains in what context the assertion takes place. It is often desirable to create this subject string from things in that context (i.e. format a string). Formatting strings that may or may not be used is however not a good practice since the formatting itself is resource consuming. This commit makes it possible to defer the formatting of the subject string until an error actually has been detected. This commit enables deferred formatting in one of two ways: 1. As an alternative to passing the subject as a String, it can now also be passed as an Array. When an Array is used, the first element is treated as a format string and the remaining elements are passed as arguments to that format string. 2. A block can be given provided to the assert call. The result of calling that block with the given subject as an argument will become the new subject. If the result is an Array, then it will be formatted as described in #1.
hlindberg
pushed a commit
that referenced
this issue
Mar 30, 2016
This commit fixes three issues in the TypeMismatchDescriber: 1. An udefined method error 'type' when comparing Hash to Struct 2. Incomprehensible output when comparing a Hash with correct size to a Struct when element type didn't match (this was never triggered due to #1). 3. To aggressive generalization when reporting mismatches where the expected type was a specialization of the actual (i.e. an expected Struct versus an actual Hash or an expected Tuple versus an actual Array).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The checks if something is adaptable or not are quite meaningless and only steals performance. No logic so far has the need to block adaptions.
The text was updated successfully, but these errors were encountered: