This repository has been archived by the owner on Feb 18, 2018. It is now read-only.
Add as namespace to validation error CSS class name
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everywhere else we use namespace CSS selectors with `as`. It makes sense to use the namespace on `error` as well - especially since `error` is a commonly used class name and thus there's a high likelihood that it could cause namespace collisions.
|
Hey. Sorry to be making changes again so quickly but I believe this corrects a small oversight on my part. I don't imagine it will be too controversial of a merge. Thanks! |
knalli
added a commit
that referenced
this pull request
Aug 20, 2013
Add `as` namespace to validation error CSS class name
|
No problem, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everywhere else we use namespace CSS selectors with
as. It makes sense to usethe namespace on
erroras well - especially sinceerroris a commonly usedclass name and thus there's a high likelihood that it could cause namespace
collisions.