Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pact-gen-ts using multiple TypeScript versions #63

Closed
pawfa opened this issue May 8, 2022 · 1 comment
Closed

Test pact-gen-ts using multiple TypeScript versions #63

pawfa opened this issue May 8, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pawfa
Copy link
Member

pawfa commented May 8, 2022

TypeScript compiler changes have a huge impact on pact-gen-ts functionality. Due to TS not following semantic versioning it is hard to predict when it might cause issues with pact-gen-ts library.

My suggestion is to test library with different versions of TypeScript - including @next. Example implementation provided here: react-redux gh action with different TS versions.

It could give us quick feedback whether the API changed in upcomfing TypeScript version

@pawfa pawfa added the enhancement New feature or request label May 8, 2022
@pawfa pawfa assigned pawfa and unassigned pawfa Oct 8, 2023
@pawfa
Copy link
Member Author

pawfa commented Oct 9, 2023

Closing issue after coming to a conclusion that this will not make maintenance easier. Having the knowledge in advance that pact-gen-ts will not work with new TypeScript version will not allow to react and fix the issue sooner. It is because most of the fixes require ts-morph update so we still have to wait for it and only after that, pact-gen-ts can be aligned with news TS version.

@pawfa pawfa closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant