Throw an error in execute() instead of returning invalid value

hluk · May 11, 2024 · 7a23987 · 7a23987
1 parent 10b36cb
commit 7a23987
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/scriptable/scriptable.cpp b/src/scriptable/scriptable.cpp
@@ -1946,8 +1946,9 @@ QJSValue Scriptable::execute()
     connect( &action, &Action::actionOutput,
              this, &Scriptable::onExecuteOutput );
 
-    if ( !runAction(&action) || action.actionFailed() )
-        return QJSValue();
+    if ( !runAction(&action) || action.actionFailed() ) {
+        return throwError( QStringLiteral("Failed to run command") );
+    }
 
     if ( m_executeStdoutCallback.isCallable() ) {
         const auto arg = toScriptValue(m_executeStdoutLastLine, m_engine);