Fix some issues found by sonarcloud

docs/conf.py

@@ -49,6 +49,7 @@
 project = 'CopyQ'
 copyright = '2024, Lukas Holecek'
 author = 'Lukas Holecek'
+title = 'CopyQ Documentation'
 
 # The version info for the project you're documenting, acts as replacement for
 # |version| and |release|, also used in various other places throughout the
@@ -131,8 +132,7 @@
 # (source start file, target name, title,
 #  author, documentclass [howto, manual, or own class]).
 latex_documents = [
-    (master_doc, 'CopyQ.tex', 'CopyQ Documentation',
-     'Lukas Holecek', 'manual'),
+    (master_doc, 'CopyQ.tex', title, author, 'manual'),
 ]
 
 
@@ -141,8 +141,7 @@
 # One entry per manual page. List of tuples
 # (source start file, name, description, authors, manual section).
 man_pages = [
-    (master_doc, 'copyq', 'CopyQ Documentation',
-     [author], 1)
+    (master_doc, 'copyq', title, [author], 1)
 ]
 
 
@@ -152,7 +151,7 @@
 # (source start file, target name, title, author,
 #  dir menu entry, description, category)
 texinfo_documents = [
-    (master_doc, 'CopyQ', 'CopyQ Documentation',
+    (master_doc, 'CopyQ', title,
      author, 'CopyQ', 'One line description of project.',
      'Miscellaneous'),
 ]

plugins/itemencrypted/itemencrypted.cpp

@@ -71,10 +71,10 @@ bool verifyProcess(QProcess *p, int timeoutMs = 30000)
     }
 
     if (exitCode != 0) {
-        const QString errors = p->readAllStandardError();
-        if ( !errors.isEmpty() )
+        if (const QString errors = p->readAllStandardError(); !errors.isEmpty()) {
             log( QStringLiteral("ItemEncrypt: GnuPG stderr:\n%1")
                  .arg(errors), LogError );
+        }
         return false;
     }
 
@@ -330,8 +330,7 @@ void startGenerateKeysProcess(QProcess *process, bool useTransientPasswordlessKe
 
 QString exportImportGpgKeys()
 {
-    const auto error = exportGpgKey();
-    if ( !error.isEmpty() )
+    if (const auto error = exportGpgKey(); !error.isEmpty())
         return error;
 
     return importGpgKey();
@@ -597,8 +596,7 @@ QString ItemEncryptedScriptable::generateTestKeys()
                       QString::fromUtf8(process.readAllStandardError()) );
     }
 
-    const auto error = exportImportGpgKeys();
-    if ( !error.isEmpty() )
+    if ( const auto error = exportImportGpgKeys(); !error.isEmpty() )
         return error;
 
     for (const auto &keyFileName : keys) {

plugins/itemfakevim/fakevim/fakevimhandler.cpp

@@ -6159,9 +6159,11 @@ bool FakeVimHandler::Private::handleExSetCommand(const ExCommand &cmd)
     if (cmd.args.contains('=')) {
         // Non-boolean config to set.
         int p = cmd.args.indexOf('=');
-        QString error = s.trySetValue(cmd.args.left(p), cmd.args.mid(p + 1));
-        if (!error.isEmpty())
+        if ( const QString error = s.trySetValue(cmd.args.left(p), cmd.args.mid(p + 1));
+                !error.isEmpty() )
+        {
             showMessage(MessageError, error);
+        }
     } else {
         QString optionName = cmd.args;
 

plugins/itemfakevim/itemfakevim.cpp

@@ -39,8 +39,8 @@ namespace {
 
 const char propertyWrapped[] = "CopyQ_fakevim_wrapped";
 
-QLatin1String configReallyEnabled("really_enable");
-QLatin1String configSourceFile("source_file");
+const QLatin1String configReallyEnabled("really_enable");
+const QLatin1String configSourceFile("source_file");
 
 // The same method for rendering document doesn't work for QPlainTextEdit.
 // This is simplified code from Qt source code.

plugins/itemnotes/itemnotes.cpp

@@ -34,9 +34,9 @@ const int defaultMaxBytes = 10*1024;
 
 const int notesIndent = 16;
 
-QLatin1String configNotesAtBottom("notes_at_bottom");
-QLatin1String configNotesBeside("notes_beside");
-QLatin1String configShowTooltip("show_tooltip");
+const QLatin1String configNotesAtBottom("notes_at_bottom");
+const QLatin1String configNotesBeside("notes_beside");
+const QLatin1String configShowTooltip("show_tooltip");
 
 QWidget *createIconWidget(const QByteArray &icon, QWidget *parent)
 {

src/platform/win/winplatformclipboard.h

@@ -17,6 +17,7 @@ class WinPlatformClipboard final : public DummyClipboard
 protected:
     void onChanged(int) override;
 
+private:
     DWORD m_lastClipboardSequenceNumber = -1;
 };
 

src/scriptable/scriptable.cpp

@@ -1025,8 +1025,7 @@ QJSValue Scriptable::removeTab()
     m_skipArguments = 1;
 
     const QString &name = arg(0);
-    const QString error = m_proxy->removeTab(name);
-    if ( !error.isEmpty() )
+    if ( const QString error = m_proxy->removeTab(name); !error.isEmpty() )
         return throwError(error);
     return QJSValue();
 }
@@ -1036,8 +1035,7 @@ QJSValue Scriptable::renameTab()
     m_skipArguments = 2;
     const QString &name = arg(0);
     const QString &newName = arg(1);
-    const QString error = m_proxy->renameTab(newName, name);
-    if ( !error.isEmpty() )
+    if ( const QString error = m_proxy->renameTab(newName, name); !error.isEmpty() )
         return throwError(error);
     return QJSValue();
 }
@@ -1117,8 +1115,7 @@ QJSValue Scriptable::remove()
     if ( rows.empty() )
         rows.append(0);
 
-    const auto error = m_proxy->browserRemoveRows(m_tabName, rows);
-    if ( !error.isEmpty() )
+    if ( const auto error = m_proxy->browserRemoveRows(m_tabName, rows); !error.isEmpty() )
         return throwError(error);
     return QJSValue();
 }
@@ -2332,8 +2329,7 @@ QJSValue Scriptable::loadTheme()
     m_skipArguments = 1;
 
     const QString path = getAbsoluteFilePath(arg(0));
-    const QString error = m_proxy->loadTheme(path);
-    if ( !error.isEmpty() )
+    if ( const QString error = m_proxy->loadTheme(path); !error.isEmpty() )
         return throwError(error);
 
     return QJSValue();
@@ -3322,8 +3318,7 @@ void Scriptable::insert(int row, int argumentsBegin, int argumentsEnd)
     m_skipArguments = argumentsEnd;
 
     const VariantMapList items{getItemList(argumentsBegin, argumentsEnd, argumentsArray())};
-    const auto error = m_proxy->browserInsert(m_tabName, row, items);
-    if ( !error.isEmpty() )
+    if ( const auto error = m_proxy->browserInsert(m_tabName, row, items); !error.isEmpty() )
         throwError(error);
 }
 

src/tests/tests.cpp

@@ -37,6 +37,7 @@
 #include <QTest>
 #include <QTimer>
 
+#include <array>
 #include <memory>
 
 #define WITH_TIMEOUT "afterMilliseconds(10000, fail); "
@@ -149,7 +150,7 @@ bool testStderr(const QByteArray &stderrData, TestInterface::ReadStderrFlag flag
     };
     // Ignore exceptions and errors from clients in application log
     // (these are expected in some tests).
-    static const std::vector<QRegularExpression> ignoreList{
+    static const std::array ignoreList{
         regex(R"(CopyQ Note \[\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}\.\d{3}\] <Client-[^\n]*)"),
 
         plain("Event handler maximum recursion reached"),
@@ -500,9 +501,11 @@ class TestInterfaceImpl final : public TestInterface {
 
     QByteArray setClipboard(const QByteArray &bytes, const QString &mime, ClipboardMode mode) override
     {
-        const QByteArray error = setClipboard( createDataMap(mime, bytes), mode );
-        if (!error.isEmpty())
+        if ( const QByteArray error = setClipboard(createDataMap(mime, bytes), mode);
+                !error.isEmpty() )
+        {
             return error;
+        }
 
         return verifyClipboard(bytes, mime);
     }