Use flask-pydantic to validate and parse arguments

Drops old v1.0 API. I could not find any usage of the old API in Fedora nor internal instances. Drops unused REQUIRED_DATA configuration.
hluk · Oct 21, 2022 · c103ad6 · c103ad6
1 parent f40a832
commit c103ad6
Show file tree

Hide file tree

Showing 9 changed files with 426 additions and 597 deletions.
diff --git a/conf/settings.py.example b/conf/settings.py.example
@@ -46,16 +46,6 @@ LOGGING = {
     },
 }
 
-# Specify which fields are required (in addition to those already required)
-#  when creating result/group/testcase.
-# If you want to set some result's extra-data as required, you can do so by
-#  prepending 'data.' to the name (e.g. 'data.arch').
-REQUIRED_DATA = {
-    'create_result': [],
-    'create_group': [],
-    'create_testcase': [],
-    }
-
 # Extend the list of allowed outcomes.
 ADDITIONAL_RESULT_OUTCOMES = []
 

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -36,12 +36,12 @@ tox = {version = "4.0.0b2", optional = true}
 tox-docker = {version = "4.0.0a2", optional = true}
 
 flask-oidc = "^1.4.0"
-Flask-RESTful = "^0.3.9"
 Flask-SQLAlchemy = "^2.5.1"
 SQLAlchemy = {version = "^1.4.39"}
 psycopg2-binary = {version = "^2.9.3"}
 alembic = "^1.8.1"
 iso8601 = "^1.0.2"
+Flask-Pydantic = "^0.11.0"
 
 [tool.poetry.extras]
 test = [

diff --git a/resultsdb/config.py b/resultsdb/config.py
@@ -67,16 +67,6 @@ class Config(object):
         },
     }
 
-    # Specify which fields are required (in addition to those already required)
-    #  when creating result/group/testcase.
-    # If you want to set some result's extra-data as required, you can do so by
-    #  prepending 'data.' to the name (e.g. 'data.arch').
-    REQUIRED_DATA = {
-        'create_result': [],
-        'create_group': [],
-        'create_testcase': [],
-        }
-
     # Extend the list of allowed outcomes.
     ADDITIONAL_RESULT_OUTCOMES = ()