feat(thought-leadership): add URL/query parameter to sidebar filters #279

sahmad-merative · 2023-07-14T12:21:22Z

Issue

Fixes #

Description

Added deep linking within each filtering within the Thought Leadership landing
filters selected are added to the url query params and when link is directly used, thought leadership page loads withfilters pre-selected
New

Changed

Removed

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Figma Link -https://www.figma.com/file/dFJwrp6VkUMSirF2KMLRMx/Thought-leadership-library?type=design&node-id=357-17807&mode=design&t=ruJDKhBVbzaP2Gnw-0

Test URLs

Before (Changes from feat/thought-leadership): https://feat-thought-leadership--merative2--hlxsites.hlx.page/thought-leadership
After (Changes from this PR): https://753-query-param-sidebar--merative2--sahmad-merative.hlx.page/thought-leadership

Testing Instruction

If applicable, please describe the tests that you ran to verify your changes. Provide instructions and link to the hlx deploy preview so that QA and the design team can provide proper testing.

aem-code-sync · 2023-07-14T12:21:24Z

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

Re-run PSI Checks

aem-code-sync · 2023-07-14T12:21:44Z

Page	Scores	Audits	Google
/thought-leadership		Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP)

proeung · 2023-07-20T13:58:32Z

@sahmad-merative #286 has been merged into the feature branch. Please rebase or open a new PR that includes the changes for exposing the query parameter for the filtering items.

aem-code-sync · 2023-07-21T10:47:23Z

Page	Scores	Audits	Google
/thought-leadership		Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP)

aem-code-sync · 2023-07-21T11:26:39Z

Page	Scores	Audits	Google
/thought-leadership		Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP)

aem-code-sync · 2023-07-21T11:28:55Z

Page	Scores	Audits	Google
/thought-leadership		Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP)

aem-code-sync · 2023-07-21T13:40:37Z

Page	Scores	Audits	Google
/thought-leadership

aem-code-sync · 2023-07-24T10:29:01Z

Page	Scores	Audits	Google
/thought-leadership

sharathmrft

@sahmad-merative @proeung
Hero banner along with the correct image is not appearing
in 'Health Insights' and 'Marketscan' pages-Refer the screenshot below.

aem-code-sync · 2023-07-24T18:09:49Z

Page	Scores	Audits	Google
/thought-leadership

proeung

@sahmad-merative Looks good overall. I just have a couple of comments/suggestions.

blocks/blog-home/blog-home.js

blocks/thought-leadership-home/thought-leadership-home.js

aem-code-sync · 2023-07-25T10:59:08Z

Page	Scores	Audits	Google
/thought-leadership

sharathmrft · 2023-07-25T12:22:15Z

@sahmad-merative @proeung

Tested all the filters URL Individually its working fine except Hero banner and the Image needs to be displayed as I mentioned above for 'Health Insights' and 'Market scan'

@Shalini-SB @keith-kaplan

proeung

@sahmad-merative Code changes look good. Thanks for addressing my feedback!

@sharathmrft The issue you were seeing was related to the page preview caches, where the script for the hero block wasn't loading and returned a 404 (see attached).

I just cleared the caches and the hero banner should be displaying correctly. Please test again - https://753-query-param-sidebar--merative2--sahmad-merative.hlx.page/thought-leadership

sharathmrft · 2023-07-26T05:39:37Z

@proeung Looks fine now.

* feat(podcast): Add podcast iframe block (#249) * Podcast block creation. * Podcast iframe block creation. * Delay js for podcast. * Refactoring of code part - 1. * Refactoring of code part-2. * CSS regactoring changes. * Update scripts/delayed.js Co-authored-by: Putra Bonaccorsi <putra.roeung@gmail.com> * Spotify and apple podcast csp changes. * Apple podcast iframe changes. --------- Co-authored-by: Putra Bonaccorsi <putra.roeung@gmail.com> * feat(podcast): Add podcast iframe block (#249) * Podcast block creation. * Podcast iframe block creation. * Delay js for podcast. * Refactoring of code part - 1. * Refactoring of code part-2. * CSS regactoring changes. * Update scripts/delayed.js Co-authored-by: Putra Bonaccorsi <putra.roeung@gmail.com> * Spotify and apple podcast csp changes. * Apple podcast iframe changes. --------- Co-authored-by: Putra Bonaccorsi <putra.roeung@gmail.com> * feat(related-documents): add purple theme and adjust rendering logic when there's no post (#250) * added card fetching functionality to Linkable cards * fixed lint issue * lint issues fixes * lint issues fixed * Added auto fetching to related documents * lint issues fixed * Update linkable-cards.css * removed commented code --------- Co-authored-by: Putra Bonaccorsi <putra.roeung@gmail.com> * feat(thought-leadership): Add "Hero banner" block (#273) * Podcast block creation. * Podcast iframe block creation. * Delay js for podcast. * Refactoring of code part - 1. * Refactoring of code part-2. * CSS regactoring changes. * Update scripts/delayed.js Co-authored-by: Putra Bonaccorsi <putra.roeung@gmail.com> * feat(thought-leadership): Add "Hero banner" * feat(thought-leadership): Js lint fix for newline. * feat(hero-banner): Css refactoring and lint fixes. * feat(hero-banner): JS refactoring. * feat(hero-banner): Code refactoring changes. --------- Co-authored-by: Putra Bonaccorsi <putra.roeung@gmail.com> * feat(thought-leadership): add sidebar filtering and results (#286) * thought leadership home added * Added content type * Fixed lint issues * Review comments addressed * Lint issues fixed * lint issue fixed * Update blog-home.js * sorting of filters added * Revert "sorting of filters added" This reverts commit eac35e9. * added sorting to side filters * removed console from script.js * Filters selection fixed * removed sorting and fixed solution categories * fixed logic of what should be shown in TL * feat(thought-leadership): change sidebar filter to assettype * feat(thought-leadership): improve the rendering of sidebar title * feat(thought-leadership): enhance getAllBlogs and getThoughtLeadership * feat(thought-leadership): adjust hero block * feat(thought-leadership): rename card classes * feat(thought-leadership): use display-title if it exists * feat(thought-leadership): adjust filter width * feat(thought-leadership): address QA feedback * feat(thought-leadership): fix filter reset count --------- Co-authored-by: Saad Ahmad <sahmed3@merative.com> Co-authored-by: Putra Bonaccorsi <putra.roeung@gmail.com> * fix(thought-leadership): result results for content type filter (#294) * feat(thought-leadership): add URL/query parameter to sidebar filters (#279) * Added query param deep linking to thought leadership * lint issues fixed * feat(thought-leadership): updated latest code * feat(thought-leadership): fixed filter issue * review comments fixed --------- Co-authored-by: Putra Bonaccorsi <putra.roeung@gmail.com> * fix(thought-leadership): render display-title if it exists (#303) * fix(thought-leadership): render display-title if it exists * fix(thought-leadership): fix lint --------- Co-authored-by: nimithshetty17 <111452145+nimithshetty17@users.noreply.github.com> Co-authored-by: sahmad-merative <135624814+sahmad-merative@users.noreply.github.com> Co-authored-by: Amol Anand <amol-anand@users.noreply.github.com> Co-authored-by: Saad Ahmad <sahmed3@merative.com>

sahmad-merative added 2 commits July 14, 2023 17:24

Added query param deep linking to thought leadership

317f4e8

lint issues fixed

4806ece

sahmad-merative added Thought Leadership Used for work related to Thought Leadership On-Hold Work is on-hold until proper sign off labels Jul 14, 2023

sahmad-merative requested review from proeung, helms-charity, amol-anand, nimithshetty17, sachinmesh, Danielcodepad and sharathmrft July 14, 2023 12:21

Merge branch 'feat/thought-leadership' into 753-query-param-sidebar

8c7fff3

feat(thought-leadership): updated latest code

9293222

sahmad-merative removed the On-Hold Work is on-hold until proper sign off label Jul 21, 2023

Merge branch 'feat/thought-leadership' into 753-query-param-sidebar

5b27cf1

feat(thought-leadership): fixed filter issue

2747da5

sharathmrft reviewed Jul 24, 2023

View reviewed changes

sahmad-merative changed the title ~~753 query param sidebar (DO NOT MERGE BEFORE #274)~~ 753 query param sidebar Jul 24, 2023

Merge branch 'feat/thought-leadership' into 753-query-param-sidebar

da95c2c

proeung changed the title ~~753 query param sidebar~~ feat(thought-leadership): add URL/query parameter to sidebar filters Jul 24, 2023

proeung suggested changes Jul 24, 2023

View reviewed changes

blocks/blog-home/blog-home.js Outdated Show resolved Hide resolved

blocks/blog-home/blog-home.js Outdated Show resolved Hide resolved

blocks/thought-leadership-home/thought-leadership-home.js Outdated Show resolved Hide resolved

review comments fixed

a0ca185

proeung approved these changes Jul 25, 2023

View reviewed changes

helms-charity approved these changes Jul 26, 2023

View reviewed changes

proeung merged commit 9ecb0fc into hlxsites:feat/thought-leadership Jul 27, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(thought-leadership): add URL/query parameter to sidebar filters #279

feat(thought-leadership): add URL/query parameter to sidebar filters #279

sahmad-merative commented Jul 14, 2023 •

edited by proeung

Loading

aem-code-sync bot commented Jul 14, 2023

aem-code-sync bot commented Jul 14, 2023

proeung commented Jul 20, 2023

aem-code-sync bot commented Jul 21, 2023

aem-code-sync bot commented Jul 21, 2023

aem-code-sync bot commented Jul 21, 2023

aem-code-sync bot commented Jul 21, 2023

aem-code-sync bot commented Jul 24, 2023

sharathmrft left a comment

aem-code-sync bot commented Jul 24, 2023

proeung left a comment

aem-code-sync bot commented Jul 25, 2023

sharathmrft commented Jul 25, 2023

proeung left a comment

sharathmrft commented Jul 26, 2023

feat(thought-leadership): add URL/query parameter to sidebar filters #279

feat(thought-leadership): add URL/query parameter to sidebar filters #279

Conversation

sahmad-merative commented Jul 14, 2023 • edited by proeung Loading

Issue

Description

Design Specs

Test URLs

Testing Instruction

aem-code-sync bot commented Jul 14, 2023

aem-code-sync bot commented Jul 14, 2023

proeung commented Jul 20, 2023

aem-code-sync bot commented Jul 21, 2023

aem-code-sync bot commented Jul 21, 2023

aem-code-sync bot commented Jul 21, 2023

aem-code-sync bot commented Jul 21, 2023

aem-code-sync bot commented Jul 24, 2023

sharathmrft left a comment

Choose a reason for hiding this comment

aem-code-sync bot commented Jul 24, 2023

proeung left a comment

Choose a reason for hiding this comment

aem-code-sync bot commented Jul 25, 2023

sharathmrft commented Jul 25, 2023

proeung left a comment

Choose a reason for hiding this comment

sharathmrft commented Jul 26, 2023

sahmad-merative commented Jul 14, 2023 •

edited by proeung

Loading