Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace megamenu background image by simple gradient #823

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Replace megamenu background image by simple gradient #823

wants to merge 4 commits into from

Conversation

jose-correia
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #758

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 4, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 4, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@jose-correia jose-correia requested a review from mhaack July 4, 2023 13:52
@jose-correia jose-correia self-assigned this Jul 4, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Jul 4, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 5, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 5, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

alexcarol
alexcarol approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@alexcarol alexcarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! It looks way smoother with the gradient than with the original image (which looks pixelated on my screen).

@mhaack
Copy link
Contributor

mhaack commented Jul 7, 2023

Let’s not merge this! This should first discussed with the customer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcarol alexcarol alexcarol approved these changes

@mhaack mhaack Awaiting requested review from mhaack

Assignees

@jose-correia jose-correia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test replacing the background image in megamenu by a gradient
3 participants
@jose-correia @mhaack @alexcarol