Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Powertrain performance graph and specs adapted to work with new re-design style #519 #580

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Powertrain performance graph and specs adapted to work with new re-design style #519 #580

merged 7 commits into from
Jul 10, 2024

Conversation

cogniSyb
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #519

Test URLs:

@cogniSyb cogniSyb linked an issue Feb 28, 2024 that may be closed by this pull request
FR: Powertrain performance graph and specs adapted to work with new re-design style #519
Closed
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Feb 28, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Feb 28, 2024 •
edited
Loading

Page Scores Audits Google
/trucks/powertrain/d11/new PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cogniSyb cogniSyb force-pushed the main branch 4 times, most recently from 45ddec5 to bf01c5d Compare April 11, 2024 18:20
@cogniSyb cogniSyb changed the base branch from main to develop May 13, 2024 15:03
@aem-code-sync aem-code-sync bot temporarily deployed to 519-engine-specifications July 3, 2024 08:26 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 519-engine-specifications July 3, 2024 08:35 Inactive
@alexiscoelho alexiscoelho self-assigned this Jul 4, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to 519-engine-specifications July 4, 2024 12:24 Inactive
@alexiscoelho alexiscoelho marked this pull request as ready for review July 4, 2024 12:24
santi-homps
santi-homps previously approved these changes Jul 4, 2024
View reviewed changes
@alexiscoelho alexiscoelho merged commit b2f261a into develop Jul 10, 2024
2 of 3 checks passed
@alexiscoelho alexiscoelho deleted the 519-engine-specifications branch July 10, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santi-homps santi-homps santi-homps approved these changes

@amglebihan amglebihan amglebihan approved these changes

@jonatan-lledo-netcentric jonatan-lledo-netcentric Awaiting requested review from jonatan-lledo-netcentric

Assignees

@alexiscoelho alexiscoelho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: Powertrain performance graph and specs adapted to work with new re-design style
6 participants
@cogniSyb @santi-homps @jonatan-lledo-netcentric @amglebihan @alexiscoelho @alexiscoelhonc