fix: preserve user-set onStop callbacks

hlysine · May 23, 2023 · 3c898f3 · 3c898f3
1 parent 3eee2f7
commit 3c898f3
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/core.ts b/src/core.ts
@@ -246,8 +246,10 @@ export const effect = (
     cleanupFn?.();
     cleanupFn = fn() ?? undefined;
   }, options);
+  const baseStop = runner.effect.onStop;
   runner.effect.onStop = () => {
     cleanupFn?.();
+    baseStop?.();
   };
   return runner;
 };
@@ -484,8 +486,10 @@ export const watch: WatchOverloads = <
     oldValue = effect();
   }
 
+  const baseStop = effect.effect.onStop;
   effect.effect.onStop = () => {
     cleanup?.();
+    baseStop?.();
   };
 
   return () => effect.effect.stop();