Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Bottom Overflow #5

Closed
YofarDev opened this issue Feb 12, 2024 · 2 comments
Closed

[bug] Bottom Overflow #5

YofarDev opened this issue Feb 12, 2024 · 2 comments
Assignees
@hm21
Labels
bug Something isn't working

Comments

@YofarDev
Copy link

Hello, I tried the package in an app on my physical device (Samsung Galaxy 10e), and got a bottom overflow warning :

Screenshot_20240212_153130
@YofarDev YofarDev added the bug Something isn't working label Feb 12, 2024
@hm21 hm21 self-assigned this Feb 12, 2024
@hm21
Copy link
Owner

hm21 commented Feb 12, 2024

Hi YofarDev,

Thank you for reporting that issue. In my opinion, is the problem from the custom IconButton in the BottomAppBar which is extended from TextButton, which seems to add varying padding on different devices. However, I've added fixed padding, which should solve this issue. I tested it on a real Samsung Galaxy S10 (not the S10e), and it appeared fine, but I'm uncertain about the S10e. Please let me know if the issue persists on your S10e.

hm21 added a commit that referenced this issue Feb 12, 2024
@hm21
fix: Resolve button overflow issue in editor interface
3ce217b 
- Refine `flat_icon_text_button.dart` to enhance button responsiveness and layout consistency across various screen sizes and resolutions, to prevent button overflow, as reported in issue [#5](#5).
@hm21 hm21 closed this as completed Feb 12, 2024
@YofarDev
Copy link
Author

Yeah it's fixed! Thanks it was quick.

@Kora3 Kora3 mentioned this issue Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hm21 hm21

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hm21 @YofarDev