Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Landscape support #7

Closed
ynnob opened this issue Feb 20, 2024 · 1 comment
Closed

Feature Request: Landscape support #7

ynnob opened this issue Feb 20, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ynnob
Copy link

ynnob commented Feb 20, 2024

Is your feature request related to a problem? Please describe.
Currently landsscape mode is not supported and the widget will always fallback to portrait mode

Describe the solution you'd like
For tablet users that mainly use our app in landscape mode this change in orientation can be confusing and in addition to that we navigate from differently oriented dynamic screens to pro_image_editor and that makes it kind of tricky to restore the orientation of the previous screen correctly.

Describe alternatives you've considered
I guess one way would be to wrap your widget into a rotation widget but i don't think this is a viable solution to the problem

Additional context
At the moment i don't really see a problem with allowing other device orientations. Only the implemented color slider might overflow on some devices. I want the user to decide in which orientation he uses the phone and maybe the color slider should be rotated horizontally in landscape mode. Most phone users will not use landscape mode in the app anyway or manually lock their screens to their prefrered orientation.

What are your thoughts on that?

@ynnob ynnob added the enhancement New feature or request label Feb 20, 2024
@hm21
Copy link
Owner

hm21 commented Feb 21, 2024

Thanks for your Feature Request.
I've updated and uploaded version 2.4.2, which now supports all device orientations. Additionally, the color slider will automatically resize if the device screen is too small. However, I believe it's unlikely that users will rotate their small smartphones to edit images, so this should not be a significant concern. While I haven't extensively tested it on tablets, please inform me if there is any issue.

@hm21 hm21 closed this as completed Feb 21, 2024
@Kora3 Kora3 mentioned this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants