Refactor demo app to fix analyzer issues

src/TaTooIne.Demo/App.razor

@@ -9,4 +9,4 @@
             <p role="alert">Sorry, there's nothing at this address.</p>
         </LayoutView>
     </NotFound>
-</Router>
+</Router>

src/TaTooIne.Demo/DemoIndicators/IndicatorChart.razor

@@ -2,18 +2,3 @@
 @inject IJSRuntime JsRuntime
 
 <section id="chart" @ref="_chartCanvas"></section>
-
-@code {
-    private ElementReference _chartCanvas;
-
-    [Parameter]
-    public Function Function { get; set; }
-
-    protected override async Task OnAfterRenderAsync(bool firstRender)
-    {
-        if (firstRender)
-        {
-            await JsRuntime.InvokeVoidAsync("SiteJsInterop.setupChart", _chartCanvas);
-        }
-    }
-}

src/TaTooIne.Demo/DemoIndicators/IndicatorChart.razor.cs

@@ -0,0 +1,21 @@
+using Microsoft.AspNetCore.Components;
+using Microsoft.JSInterop;
+using TALib;
+
+namespace TaTooIne.Demo.DemoIndicators;
+
+public partial class IndicatorChart
+{
+    private ElementReference _chartCanvas;
+
+    [Parameter]
+    public required Function Function { get; set; }
+
+    protected override async Task OnAfterRenderAsync(bool firstRender)
+    {
+        if (firstRender)
+        {
+            await JsRuntime.InvokeVoidAsync("SiteJsInterop.setupChart", _chartCanvas);
+        }
+    }
+}

src/TaTooIne.Demo/DemoIndicators/IndicatorData.razor

@@ -3,7 +3,9 @@
 <section id="calculation">
     @if (State == null)
     {
-        <p><em>Loading...</em></p>
+        <p>
+            <em>Loading...</em>
+        </p>
     }
     else
     {
@@ -23,47 +25,22 @@
             </tr>
             </thead>
             <tbody>
-                @foreach (var row in _transposedState)
-                {
-                    <tr>
-                        <td>@row.First().Time.ToShortDateString()</td>
-                        @foreach (var cell in row)
-                        {
-                            <td>
-                                @if (cell != null)
-                                {
-                                    @($"{cell.Value:F2}")
-                                }
-                            </td>
-                        }
-                    </tr>
-                }
+            @foreach (var row in _transposedState)
+            {
+                <tr>
+                    <td>@row.First().Time.ToShortDateString()</td>
+                    @foreach (var cell in row)
+                    {
+                        <td>
+                            @if (cell != null)
+                            {
+                                @($"{cell.Value:F2}")
+                            }
+                        </td>
+                    }
+                </tr>
+            }
             </tbody>
         </table>
     }
 </section>
-
-@code {
-    [Parameter]
-    public CalculatedState State { get; set; }
-
-    private IEnumerable<IEnumerable<Line>> _transposedState;
-
-    protected override void OnParametersSet()
-    {
-        if (State != null)
-        {
-            _transposedState = Transpose(State.InputValues.Concat(State.OutputValues));
-        }
-    }
-
-    private static IEnumerable<IEnumerable<T>> Transpose<T>(IEnumerable<IEnumerable<T>> @this)
-    {
-        var enumerators = @this.Select(t => t.GetEnumerator()).Where(e => e.MoveNext());
-
-        while (enumerators.Any()) {
-            yield return enumerators.Select(e => e.Current);
-            enumerators = enumerators.Where(e => e.MoveNext());
-        }
-    }
-}

src/TaTooIne.Demo/DemoIndicators/IndicatorData.razor.cs

@@ -0,0 +1,39 @@
+using Microsoft.AspNetCore.Components;
+using TaTooIne.Demo.Models;
+
+namespace TaTooIne.Demo.DemoIndicators;
+
+public partial class IndicatorData
+{
+    [Parameter]
+    public CalculatedState? State { get; set; }
+
+    private IEnumerable<IEnumerable<Line?>> _transposedState = null!;
+
+    protected override void OnParametersSet()
+    {
+        if (State != null)
+        {
+            _transposedState = Transpose(State.InputValues.Concat(State.OutputValues));
+        }
+    }
+
+    private static IEnumerable<IEnumerable<T?>> Transpose<T>(IEnumerable<IEnumerable<T?>> source)
+    {
+        // ReSharper disable once NotDisposedResourceIsReturned
+        var enumerators = source.Select(e => e.GetEnumerator()).Where(e => e.MoveNext()).ToList();
+
+        try
+        {
+            while (enumerators.Count != 0)
+            {
+                yield return enumerators.Select(e => e.Current);
+                enumerators = enumerators.Where(e => e.MoveNext()).ToList();
+            }
+        }
+        finally
+        {
+            enumerators.ForEach(e => e.Dispose());
+        }
+    }
+}

src/TaTooIne.Demo/DemoIndicators/IndicatorsIndex.razor

@@ -9,22 +9,24 @@
         </button>
         <div class="docs-toc-wrap">
             <ul id="docs-toc" class="docs-toc">
-                @for (var i = 0; i < _groups.Capacity; i++)
+                @for (var i = 0; i < _groups.Count - 1; i++)
                 {
-                    var closureI = i;
-                    <li class="toc-item has-children @NavMenuCssClass(closureI)">
-                        <button type="button" class="button-icon" @onclick="() => ToggleActive(closureI)">
+                    var localI = i;
+                    <li class="toc-item has-children @NavMenuCssClass(localI)">
+                        <button type="button" class="button-icon" @onclick="() => ToggleActive(localI)">
                             @_groups[i].Key
                         </button>
-                        <button type="button" class="submenu-toggle" @onclick="() => ToggleActive(closureI)">
+                        <button type="button" class="submenu-toggle" @onclick="() => ToggleActive(localI)">
                             <span class="screen-reader-text">Submenu</span>
                             <span class="icon-angle-right" aria-hidden="true"></span>
                         </button>
                         <ul class="toc-submenu">
                             @foreach (var ind in _groups[i])
                             {
                                 <li class="toc-item">
-                                    <button type="button" class="button-icon" @onclick="() => OnIndicatorSelect.InvokeAsync(ind)" @onclick:stopPropagation="true">
+                                    <button type="button" class="button-icon"
+                                            @onclick="() => OnIndicatorSelect.InvokeAsync(ind)"
+                                            @onclick:stopPropagation="true">
                                         @ind.Name
                                     </button>
                                 </li>
@@ -36,26 +38,3 @@
         </div>
     </div>
 </nav>
-
-@code {
-    private bool _navMenuOpened;
-    private List<IGrouping<string, Function>> _groups;
-    private int ActiveGroupId { get; set; } = -1;
-
-    [Parameter] public EventCallback<Function> OnIndicatorSelect { get; set; }
-
-    protected override void OnInitialized()
-    {
-        _groups = new Functions().Where(g => g.Group != "Math Transform").GroupBy(f => f.Group).ToList();
-    }
-
-    private string NavMenuCssClass(int groupId) => ActiveGroupId == groupId ? "active" : null;
-
-    private void ToggleActive(int groupId) => ActiveGroupId = ActiveGroupId == groupId ? -1 : groupId;
-
-    private async Task ToggleNavMenuAsync()
-    {
-        _navMenuOpened = !_navMenuOpened;
-        await JsRuntime.InvokeVoidAsync("SiteJsInterop.collapseNavMenu", _navMenuOpened, "toc");
-    }
-}

src/TaTooIne.Demo/DemoIndicators/IndicatorsIndex.razor.cs

@@ -0,0 +1,31 @@
+using Microsoft.AspNetCore.Components;
+using Microsoft.JSInterop;
+using TALib;
+
+namespace TaTooIne.Demo.DemoIndicators;
+
+public partial class IndicatorsIndex
+{
+    private bool _navMenuOpened;
+    private List<IGrouping<string, Function>> _groups = null!;
+
+    private int ActiveGroupId { get; set; } = -1;
+
+    [Parameter]
+    public EventCallback<Function> OnIndicatorSelect { get; set; }
+
+    protected override void OnInitialized()
+    {
+        _groups = Functions.All.Where(g => g.Group != "Math Transform").GroupBy(f => f.Group).ToList();
+    }
+
+    private string? NavMenuCssClass(int groupId) => ActiveGroupId == groupId ? "active" : null;
+
+    private void ToggleActive(int groupId) => ActiveGroupId = ActiveGroupId == groupId ? -1 : groupId;
+
+    private async Task ToggleNavMenuAsync()
+    {
+        _navMenuOpened = !_navMenuOpened;
+        await JsRuntime.InvokeVoidAsync("SiteJsInterop.collapseNavMenu", _navMenuOpened, "toc");
+    }
+}

src/TaTooIne.Demo/Models/CalculatedState.cs

@@ -1,17 +1,14 @@
-using System.Collections.Generic;
+namespace TaTooIne.Demo.Models;
 
-namespace TaTooIne.Demo.Models
+public sealed class CalculatedState
 {
-    public class CalculatedState
-    {
-        public string FuncDescription { get; set; }
+    public required string FuncDescription { get; init; }
 
-        public IReadOnlyCollection<string> InputNames { get; set; }
+    public required IReadOnlyCollection<string> InputNames { get; init; }
 
-        public IReadOnlyCollection<string> OutputNames { get; set; }
+    public required IReadOnlyCollection<string> OutputNames { get; init; }
 
-        public IReadOnlyCollection<IReadOnlyCollection<Line>> InputValues { get; set; }
+    public required IReadOnlyCollection<IReadOnlyCollection<Line?>> InputValues { get; init; }
 
-        public IReadOnlyCollection<IReadOnlyCollection<Line>> OutputValues { get; set; }
-    }
-}
+    public required List<List<Line?>> OutputValues { get; init; }
+}

src/TaTooIne.Demo/Models/Candle.cs

@@ -1,19 +1,16 @@
-using System;
+namespace TaTooIne.Demo.Models;
 
-namespace TaTooIne.Demo.Models
+public sealed class Candle
 {
-    public sealed class Candle
-    {
-        public DateTime Time { get; set; }
+    public DateTime Time { get; init; }
 
-        public decimal Open { get; set; }
+    public double Open { get; init; }
 
-        public decimal High { get; set; }
+    public double High { get; init; }
 
-        public decimal Low { get; set; }
+    public double Low { get; init; }
 
-        public decimal Close { get; set; }
+    public double Close { get; init; }
 
-        public decimal Volume { get; set; }
-    }
+    public double Volume { get; init; }
 }

src/TaTooIne.Demo/Models/CandleCsvMapping.cs

@@ -1,18 +1,16 @@
-using System;
-using TinyCsvParser.Mapping;
+using TinyCsvParser.Mapping;
 
-namespace TaTooIne.Demo.Models
+namespace TaTooIne.Demo.Models;
+
+public class CandleCsvMapping : CsvMapping<Candle>
 {
-    public class CandleCsvMapping : CsvMapping<Candle>
+    public CandleCsvMapping()
     {
-        public CandleCsvMapping()
-        {
-            MapProperty(0, x => x.Time, new SpecifiedKindDateTimeConverter(DateTimeKind.Utc));
-            MapProperty(1, x => x.Open);
-            MapProperty(2, x => x.High);
-            MapProperty(3, x => x.Low);
-            MapProperty(4, x => x.Close);
-            MapProperty(5, x => x.Volume);
-        }
+        MapProperty(0, x => x.Time, new SpecifiedKindDateTimeConverter(DateTimeKind.Utc));
+        MapProperty(1, x => x.Open);
+        MapProperty(2, x => x.High);
+        MapProperty(3, x => x.Low);
+        MapProperty(4, x => x.Close);
+        MapProperty(5, x => x.Volume);
     }
-}
+}

src/TaTooIne.Demo/Models/Line.cs

@@ -1,11 +1,8 @@
-using System;
+namespace TaTooIne.Demo.Models;
 
-namespace TaTooIne.Demo.Models
+public sealed record Line
 {
-    public sealed class Line
-    {
-        public DateTime Time { get; set; }
+    public required DateTime Time { get; init; }
 
-        public decimal Value { get; set; }
-    }
+    public required double Value { get; init; }
 }