Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ip Range Allow deliveries/Require SMTP authentication Bug #287

Closed
RvdHout opened this issue Jul 5, 2019 · 5 comments
Closed

Ip Range Allow deliveries/Require SMTP authentication Bug #287

RvdHout opened this issue Jul 5, 2019 · 5 comments

Comments

@RvdHout
Copy link
Contributor

RvdHout commented Jul 5, 2019

Have been fiddling around with the IP ranges, when I disallow Deliveries from External to External for a IP Range but do not uncheck External to External in Require SMTP authentication the error message displayed is:
"530 SMTP authentication is required."

Only if I also uncheck External to External in Require SMTP authentication the error message is correct. eg:
"550 Delivery is not allowed to this address."

This seems incorrect to me...Don't you think?
I think settings in Allow deliveries must always be the preferred and appointed criteria above settings in Require SMTP authentication, in Administrator GUI this looks to be the case as the Require SMTP authentication checkbox is greyed-out/readonly as soon you uncheck Allow deliveries, but in the code it seems to function visa versa

https://github.com/hmailserver/hmailserver/blob/master/hmailserver/source/Server/SMTP/SMTPConnection.cpp#L681

@mstenz
Copy link

mstenz commented Jul 5, 2019

I have experienced same issue also after first configuration of the server, it was quite confusing.

@RvdHout
Copy link
Contributor Author

RvdHout commented Jul 5, 2019

I think simply flipping over the order of execution fixes this...weird i never noticed this before

@RvdHout
Copy link
Contributor Author

RvdHout commented Jul 6, 2019

RvdHout added a commit to RvdHout/hmailserver that referenced this issue Aug 16, 2019
SMTP multiply max message size with 1024 issue hmailserver#267
Add email address variable to SignatureAdder.cpp pull hmailserver#265
DKIM on acccount-rule 'reply' not applied hmailserver#172 issue hmailserver#172
preserve RewriteEnvelopeFromWhenForwarding setting when forwarding from account rule
The logical flow should be to disregard "Require SMTP authentication" if "Allow deliveries from" is unselected issue hmailserver#287
@martinknafve
Copy link
Collaborator

@RvdHout I fixed this before I noticed your pull request. I'll compare our fixes and see if they are the same.

martinknafve pushed a commit that referenced this issue Aug 16, 2019
…#294)

Multiple fixes:

SMTP multiply max message size with 1024 issue #267
Add email address variable to SignatureAdder.cpp pull #265
DKIM on acccount-rule 'reply' not applied #172 issue #172
preserve RewriteEnvelopeFromWhenForwarding setting when forwarding from account rule
The logical flow should be to disregard "Require SMTP authentication" if "Allow deliveries from" is unselected issue #287
@martinknafve
Copy link
Collaborator

Merged

martinknafve added a commit that referenced this issue Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants