Session cookie approach #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use the Session Cookie approach recommended by the AngularJS project. It works for the login but then starts failing. Spring Security generates a new XSRF token after the login, and it sends it to the browser in the cookie. But Angular only reads that cookie once on the first request, and never checks for a new value.
So to get this to work we'd still have to modify AngularJS code to reload the new XSRF token. Or find a way for Spring Security to not change the XSRF token value. Or maybe modify the jHipster code to refresh the $http factories somehow after the login.
For these reasons the best is probably to just use the CSRF Token in Response Headers approach. But I'll leave this pull request and commit info here for explanation reasons.