Add reproducible example of an option not passed on #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reproduces the issue #37 .
./test/open-with-password/start-redis-container.sh
.node ./test/open-with-password/open-with-password.js
.The second command fails with the current version of redisdown.
If the
_makeRedisId
function is adjusted (adding "password" to the array or merging the options with the to be added options for example), then it successfully opens and closes.