Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reproducible example of an option not passed on #38

Closed
wants to merge 1 commit into from

Conversation

fboeller
Copy link

@fboeller fboeller commented Oct 9, 2020

This PR reproduces the issue #37 .

  1. Build and run password-protected redis container: ./test/open-with-password/start-redis-container.sh.
  2. Run node ./test/open-with-password/open-with-password.js.

The second command fails with the current version of redisdown.
If the _makeRedisId function is adjusted (adding "password" to the array or merging the options with the to be added options for example), then it successfully opens and closes.

@seigel
Copy link
Collaborator

seigel commented Oct 9, 2020

Thank you. That gives me and Idea of what you are seeing. I'm just fighting with some tests right now and will hopefully get something together when I understand what I am forgetting :)

@seigel seigel closed this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants