Stronger typing for Archetype #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 93c2edf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi, thanks for the PR! I'm going to play around with it today, but I think the changes are sane. May I ask you to exclude the changes to
|
|
yes! |
|
Hi, can you change this PR so it does not delete |
|
Oof 😮💨 - wrong file! sorry, that's amended and squashed. |
hmans
approved these changes
Aug 2, 2022
|
Thank you! \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm playing around with this library for a game project and enjoying it so far ✌️. I ran into a few hiccups with the typings for Archetype and I think these changes make sense - let me know if I misunderstood something.
– Entities emitted by
onEntityAddedcan have their type narrowed by the query– But I think those in
onEntityRemovedcan't, because they may have been removed for no longer matching the query?–
firstcan return null, but the inferred type didn't know that– and I also added an assertion to
entityIsArchetypesoArchetype.indexEntityno longer needs to useany.