Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

"cast-shadows" should map to "castShadows", not "castshadows" or "castShadows" #14

Closed
hmans opened this issue Jan 14, 2021 · 0 comments
Closed

Comments

@hmans
Copy link
Owner

hmans commented Jan 14, 2021

What we're doing today:

An attribute named castshadows will result in setting the castShadows property on the object wrapped by the element (since applyProps is currently scanning lower-cased property names as a fallback.)

Hyphens are currently interpreted to "enter" an object, ie. an attribute of foo-bar would set object.foo.bar.

What we should be doing:

  • cast-shadows should set object.castShadows
  • foo:bar should set object.foo.bar
@hmans hmans closed this as completed in dd2439d Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant