Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP BXMSDOC-5425: Added example for DMNRuntimeListener property as part of kmodule.xml #16

Merged
merged 2 commits into from
Jun 22, 2020

Conversation

@hmanwani-rh hmanwani-rh changed the title BXMSDOC-5425: Added example for DMNRuntimeListener property as part of kmodule.xml WIP BXMSDOC-5425: Added example for DMNRuntimeListener property as part of kmodule.xml May 8, 2020
Copy link

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

+
--
----
-Dorg.kie.dmn.runtime.listeners.mylistener=org.acme.MyDMNListener
----
//kept removed `[source]` for this last snippet because it rendered unlike all the others in community output otherwise for some reason. as per SJR comment above.
--
+
You can also configure this property in the `kmodule.xml` file in your project.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion:
You can remove the word also from the sentence.
You can configure this property in the kmodule.xml file in your project.

Copy link

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion. Otherwise looks good to me. :)

</configuration>
</kmodule>
----
//kept removed `[source]` for this last snippet because it rendered unlike all the others in community output otherwise for some reason. as per SJR comment above.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried [source,xml] ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jomarko , @hmanwani-rh , I had tried that before, a community rendering issue nonetheless. However, since then a several pom updates occurred, so I just retried, and it's apparently resolved.

So @hmanwani-rh , you can remove the comments and add the source definitions. Also, beware of the formatting use of + and -- You use them to start and end the block, not between every line as you have done.

For you convenience, you can simply copy and paste the following segment entirely over the same in your file. This contains the updated source defs, removed comments, your property update, and the correct formatting.

org.kie.dmn.profiles.$PROFILE_NAME::
When valorized with a Java fully qualified name, this property loads a DMN profile onto the {DECISION_ENGINE} at start time. You can use this property to implement a predefined DMN profile with supported features different from or beyond the DMN standard. For example, if you are creating DMN models using the Signavio DMN modeller, use this property to implement features from the Signavio DMN profile into your DMN decision service.
+
--
[source]
----
-Dorg.kie.dmn.profiles.signavio=org.kie.dmn.signavio.KieDMNSignavioProfile
----
--

org.kie.dmn.runtime.listeners.$LISTENER_NAME::
When valorized with a Java fully qualified name, this property loads and registers a DMN Runtime Listener onto the {DECISION_ENGINE} at start time. You can use this property to register a DMN listener in order to be notified of several events during DMN model evaluations.
+
--
[source]
----
-Dorg.kie.dmn.runtime.listeners.mylistener=org.acme.MyDMNListener
----

You can also configure this property in the `kmodule.xml` file in your project.

[source,xml]
----
<kmodule xmlns="http://www.drools.org/xsd/kmodule">
  <configuration>
    <property key="org.kie.dmn.runtime.listeners.mylistener" value="org.acme.MyDMNListener"/>
  </configuration>
</kmodule>
----
--

org.kie.dmn.compiler.execmodel::
When enabled, this property enables DMN decision table logic to be compiled into executable rule models during run time. You can use this property to evaluate DMN decision table logic more efficiently. This property is helpful when the executable model compilation was not originally performed during project compile time. Enabling this property may result in added compile time during the first evaluation by the {DECISION_ENGINE}, but subsequent compilations are more efficient.
+
--
Default value: `false`

[source]
----
-Dorg.kie.dmn.compiler.execmodel=true
----
--

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sterobin, thank you, do you wish my approval or should I recheck one those source blocks are updated? For me both is fine.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sterobin Thanks, will make the suggested changes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jomarko, up to @hmanwani-rh , but imo, not necessary for your re-approval.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, please assume my approval as final

@hmanwani-rh hmanwani-rh merged commit 026ebd0 into BXMSDOC-5425-master-final Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants