WIP BXMSDOC-5900: Added lambda introspection section in performance tuning chapter #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmanwani-rh
changed the title
tkobayas
suggested changes
May 28, 2020
| @@ -36,3 +36,6 @@ try { | |||
|
|
|||
| For information about built-in event listeners and debug logging in the {DECISION_ENGINE}, see xref:engine-event-listeners-con_decision-engine[]. | |||
| -- | |||
|
|
|||
| Use lambda introspection for executable models to configure the cache size:: | |||
There was a problem hiding this comment.
LambdaIntrospector is used internally by default. This configuration is not to 'enable' it but to change the cache size. So the sentence would be like
Configure LambdaIntrospector cache size for executable model build::
| @@ -36,3 +36,6 @@ try { | |||
|
|
|||
| For information about built-in event listeners and debug logging in the {DECISION_ENGINE}, see xref:engine-event-listeners-con_decision-engine[]. | |||
| -- | |||
|
|
|||
| Use lambda introspection for executable models to configure the cache size:: | |||
| You can enable lambda introspection to configure the size of `LambdaIntrospector.methodFingerprintsMap` cache. The default size of the cache for an executable model is `32`. Small cache size optimizes the usage of memory for an executable model. For example, you can configure system property `drools.lambda.introspector.cache.size` to `0` for optimized memory usage. | |||
There was a problem hiding this comment.
The explanation seems to encourage to set small cache size. But the default size '32' is fine for most cases. I think we should state it is a trade-off between memory and performance. So it would be like
You can configure the size of `LambdaIntrospector.methodFingerprintsMap` cache which is used in executable model build. The default size of the cache is `32`. Smaller cache size reduces the usage of memory while it may slow down the build performance. For example, you can configure system property `drools.lambda.introspector.cache.size` to `0` for the least memory usage.
kaldesai
approved these changes
May 29, 2020
There was a problem hiding this comment.
Hey @hmanwani-rh , I reviewed the section and everything looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Use lambda introspection for executable models to configure the cache size section in performance tuning chapter
See JIRA: https://issues.redhat.com/browse/BXMSDOC-5900
Rendered Output:
Decision engine in Red Hat Process Automation Manager
Decision engine in Red Hat Decision Manager