Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP BXMSDOC-5984: Added best practice for Kie server endpoints in DMN #63

Merged
merged 3 commits into from Jun 16, 2021

Conversation

hmanwani-rh
Copy link
Owner

See JIRA: https://issues.redhat.com/browse/BXMSDOC-5984

Added the best practice for the REST endpoint of KIE Server.

Doc preview
RHPAM - Designing a decision service using DMN models
RHDM - Designing a decision service using DMN models

Copy link

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about using the expected variable? Or was this done on purpose?

Just a thought, otherwise is fine, thank you!

@@ -3,6 +3,8 @@

Directly interacting with the REST endpoints of {KIE_SERVER} provides the most separation between the calling code and the decision logic definition. The calling code is completely free of direct dependencies, and you can implement it in an entirely different development platform such as `Node.js` or `.NET`. The examples in this section demonstrate Nix-style curl commands but provide relevant information to adapt to any REST client.

When you use a REST endpoint of KIE Server, the best practice is to define a domain object POJO Java class, annotated with standard KIE Server marshalling annotations.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When you use a REST endpoint of KIE Server, the best practice is to define a domain object POJO Java class, annotated with standard KIE Server marshalling annotations.
When you use a REST endpoint of {KIE_SERVER}, the best practice is to define a domain object POJO Java class, annotated with standard {KIE_SERVER} marshalling annotations.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for catching that Matteo.

Copy link

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hmanwani-rh, Your changes look good to me. Thank you.

@hmanwani-rh hmanwani-rh merged commit 20817b2 into BXMSDOC-5984-master-final Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants