Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional input force-review #208

Closed
wants to merge 1 commit into from

Conversation

vincejv
Copy link
Contributor

@vincejv vincejv commented Oct 20, 2022

When input force-review is true, re-approves the pull request even if the current review state is already APPROVED

Fixes #206

When force-review is true, re-approves the pull request even if current
review state is already approved
@hmarr
Copy link
Owner

hmarr commented Oct 20, 2022

Thanks for putting this together.

An alternative solution to #206 would be to hit the requested_reviewers API, and leave the approval if there's an open review request for the authenticated user. It should be an easy change to make.

What do you think?

@vincejv
Copy link
Contributor Author

vincejv commented Oct 20, 2022

An alternative solution to #206 would be to hit the requested_reviewers API, and leave the approval if there's an open review request for the authenticated user. It should be an easy change to make.

Will do this instead, sorry not too familiar with Github API, will PR if I figure it out

@hmarr
Copy link
Owner

hmarr commented Oct 20, 2022

@vincejv I was cleaning up the tests for this project anyway, so I went ahead and introduced the check for requested reviewers in #209 – feel free to have a look and try that branch out to check it does what you want.

You can try using that branch by temporarily switching to uses: hmarr/auto-approve-action@reapprove-on-request.

@vincejv
Copy link
Contributor Author

vincejv commented Oct 20, 2022

closed in favor of #209

@vincejv vincejv closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action does not perform review when requesting for re-review
2 participants