Active storage transaction fix #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sending them via email to avoid getting a ActiveStorage::FileNotFoundError dues to transactional nature of ActiveStorage on Rails 6."" This reverts commit e76bdf7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
config.active_job.queue_adapter = :inlineActiveStorage attachments were not ready to be downloaded from inside the same transaction that is not yet commited. See this issue: rails/rails#36994So to fix this issue we now are generating all the files outside of the ProcessOrderJob transaction. This is not a problem when we use sidekiq as the queue backend because it will run in a background job outside of the original transaction.