Make externalAuthenticationType configurable (#29)

hmcts · Aug 2, 2023 · 1a4bfb9 · 1a4bfb9
1 parent 7f22bb0
commit 1a4bfb9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/apps.schema.json b/apps.schema.json
@@ -37,6 +37,12 @@
               "https://raw.githubusercontent.com/hmcts/azure-app-proxy/main/logos/incident-bot.png"
             ]
           },
+          "externalAuthenticationType": {
+            "type": "string",
+            "default": "aadPreAuthentication",
+            "title": "externalAuthenticationType to be set on application onPremisesPublishing setting. Defaults to aadPreAuthentication ",
+            "examples": ["passthru"]
+          },
           "groupMembershipClaims": {
             "type": "string",
             "default": "",

diff --git a/src/configuration.ts b/src/configuration.ts
@@ -4,7 +4,6 @@ import { Application } from "./application.js";
 
 // TODO merge with config
 export function defaultOnPremisesFlags(): {
-  externalAuthenticationType: "aadPreAuthentication";
   isHttpOnlyCookieEnabled: boolean;
   isOnPremPublishingEnabled: boolean;
   isPersistentCookieEnabled: boolean;
@@ -13,7 +12,6 @@ export function defaultOnPremisesFlags(): {
   isTranslateLinksInBodyEnabled: boolean;
 } {
   return {
-    externalAuthenticationType: "aadPreAuthentication",
     isHttpOnlyCookieEnabled: true,
     isOnPremPublishingEnabled: true,
     isPersistentCookieEnabled: true,
@@ -43,6 +41,9 @@ export async function loadApps(configFilePath: string): Promise<Application[]> {
       onPremisesPublishing: {
         externalUrl: app.externalUrl,
         internalUrl: app.internalUrl,
+        externalAuthenticationType: app.externalAuthenticationType
+          ? app.externalAuthenticationType
+          : "aadPreAuthentication",
         ...defaultOnPremisesFlags(),
       },
       groupMembershipClaims: app.groupMembershipClaims,

diff --git a/src/onPremisesPublishing.ts b/src/onPremisesPublishing.ts
@@ -1,5 +1,5 @@
 export type OnPremisesPublishing = {
-  externalAuthenticationType: "aadPreAuthentication";
+  externalAuthenticationType: string;
   externalUrl: string;
   internalUrl: string;
   isHttpOnlyCookieEnabled: boolean;