Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating functions for role/group assignment to be more specific when searching for the base User group #144

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Updating functions for role/group assignment to be more specific when searching for the base User group #144

merged 8 commits into from
Jan 23, 2024

Conversation

MartyFox
Copy link
Contributor

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/DTSPO-15781

Change description

Updating functions for role/group assignment to be more specific when searching for the base User group, this fixes a bug where a group having more than 1 role assigned caused a duplicate permission issue as the code searched for the first found.

Updating apps.yaml as the use case only appears when a group is a member of appRoleAssignment and an appRole which was not the case in the test file.

timja
timja reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simpler

src/servicePrincipalManager.ts Outdated Show resolved Hide resolved
src/servicePrincipalManager.ts Outdated Show resolved Hide resolved
@MartyFox
Copy link
Contributor Author

Test output

 ✓ src/applicationManager.test.ts (4) 62277ms
   ✓ applicationManager (4) 62277ms
     ✓ happy path 16006ms
     ✓ finds existing application when creating 2836ms
     ✓ setLogo does nothing if no logo 10082ms
     ✓ setResourceAccess - one appRole and one oauth2 permission scope 31840ms

@MartyFox MartyFox merged commit aeee8d4 into main Jan 23, 2024
1 check passed
@MartyFox MartyFox deleted the marty/DTSPO-15781-bugfix branch January 23, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

@reespozzi reespozzi Awaiting requested review from reespozzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MartyFox @timja