Updated README.md as per issue #288 #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
requested changes
Apr 3, 2022
|
You're totally right. Should I cancel the PR, add the instructions in the
README and create a new PR? Thx!
…---
Michail L. Liarmakopoulos, MSc
On Sun, Apr 3, 2022, 15:11 Pol Dellaiera ***@***.***> wrote:
***@***.**** requested changes on this pull request.
That's a good start!
However, the link to enable flakes features is pointing to a wiki, which
might be subject to change. Maybe it would be better to include those steps
in stone in this readme ? WDYT ?
—
Reply to this email directly, view it on GitHub
<#289 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMQENTCVQYH7QT4TACHQLDVDGKGTANCNFSM5SNFCNHQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
You can just update this PR by pushing to this branch ! :) |
|
Thanks !! |
|
? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit the instructions in the README.md weren't accurate enough to allow one to build the Scala version of the PDF following them (
makeandmake scalafailed miserably).In this commit I did my best to transfer the updated instructions that were given by @drupol at issue #288 and I can confirm that they work like a charm on my GNU/Linux laptop.
Thanks !