Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ingredients .json files with happycow data #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

annalisetarhan
Copy link

Most of the changes were moving ingredients from notvegan to canbevegan according to HappyCow's list. Just a few were moving from canbevegan to notvegan, mostly tallow products (none of the sources listed in the readme support a vegan version of tallow, and I couldn't find anything else that did). Other changes were cleanup and adding ingredient variations. Also added HappyCow as a source in the readme. Justifications for changes in the google doc: https://docs.google.com/spreadsheets/d/1puByX37M3Dbu2dJvsoCVFI1TjbBtx0ZvF-PrzYuARIY/edit?usp=sharing

@hmontazeri
Copy link
Owner

hmontazeri commented Jun 18, 2020

@annalisetarhan thanks for the PR. Could you please check the CI?

https://travis-ci.org/github/hmontazeri/is-vegan/jobs/699300029

Seems like the JSON files have syntax errors. Somewhere in nonvegan.json.

@hmontazeri
Copy link
Owner

@annalisetarhan unfortunately it's still failing.
The tests don't pass anymore, probably because the ingredients in the test cases aren't correct anymore. Could you please have look at those?

https://travis-ci.org/github/hmontazeri/is-vegan/jobs/700027479#L260
https://travis-ci.org/github/hmontazeri/is-vegan/jobs/700027479#L263

@annalisetarhan
Copy link
Author

Fingers crossed :)

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           31        31           
  Branches         7         7           
=========================================
  Hits            31        31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56029e...5bdae97. Read the comment docs.

@hmontazeri
Copy link
Owner

@annalisetarhan looks good. Going to merge it the coming days. Thanks for your effort!

@lucasrodes lucasrodes mentioned this pull request Jun 29, 2020
@lucasrodes
Copy link

Hi,
Just wondering how we can manage to keep all language files aligned when there are updates in one of them.
updates on a certain language list to be aligned with other languages?

Just thought of this when creating #41

@hmontazeri
Copy link
Owner

@lucasrodes That’s a very good question. I guess the easiest way would be having a maintainer for each language?

@lucasrodes
Copy link

@hmontazeri I agree with that. I'll give it a thought or two!

@moetelo
Copy link

moetelo commented Feb 10, 2021

Any updates on this? @hmontazeri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants