-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sass linting #228
Comments
oops |
Have just done a setup with sass and https://github.com/sasstools/sass-lint using the rule
And then using post-css with the plugin https://github.com/cuth/postcss-pxtorem to convert px to rem. |
@feedmypixel Having considered this some more, I think we'd be better off moving margins and paddings into variables with It feels like a very heavy handed approach though, but I worry that by allowing the use of arbitrary magic numbers all over the place we'll struggle to maintain consistency in components and layouts. |
Also, we should probably consider using stylelint over sass-lint for it's modularity (e.g. stylelint-selector-bem-pattern). Much the same as eslint for js |
👍 on stylelint we could
Potentially we would also write a plugin so people can’t More of a guidance than a heavy handed approach |
...to keep things tidy.
https://github.com/sasstools/sass-lint
The text was updated successfully, but these errors were encountered: