Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring tables to be more BEM #396

Closed
timsb opened this issue Feb 10, 2016 · 2 comments
Closed

Refactoring tables to be more BEM #396

timsb opened this issue Feb 10, 2016 · 2 comments

Comments

@timsb
Copy link
Contributor

timsb commented Feb 10, 2016

Currently it looks like the tables sass file could do with a bit more BEM love and consideration of structure.
https://github.com/hmrc/assets-frontend/blob/master/assets/scss/base/_table.scss

It would be useful to look over the tables elements and think about how this can be restructured.
By having a solid structure it could potentially help any other users submitting code in the future.
@feedmypixel
Copy link
Contributor

worth referencing this PR #394 and comments made

@gavinwye
Copy link
Contributor

gavinwye commented Dec 6, 2017

should come from GOV.UK

@gavinwye gavinwye closed this as completed Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gavinwye @feedmypixel @timsb