Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of margin and padding helpers #61

Closed
rpowis opened this issue Feb 18, 2015 · 3 comments
Closed

Duplication of margin and padding helpers #61

rpowis opened this issue Feb 18, 2015 · 3 comments

Comments

@rpowis
Copy link
Contributor

rpowis commented Feb 18, 2015

Are these necessary? If not, they should be consolidated and the corresponding markup refactored.

https://github.com/hmrc/assets-frontend/blob/master/assets/scss/base/_helpers.scss#L35-L85

@gavinwye
Copy link
Contributor

gavinwye commented May 2, 2017

We need to investigate this and find out which services these classes are being used in and why they are being used.

@rpowis
Copy link
Contributor Author

rpowis commented May 2, 2017

In order to get rid of these for good, we should work out which are the most commonly used and incorporate them into the component and patterns they're being used for.

@gordonmcmullan
Copy link
Contributor

These no longer appear in the v4.x.x line of releases, closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants