Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up unused files #702

Closed
feedmypixel opened this issue Nov 10, 2016 · 5 comments
Closed

Tidy up unused files #702

feedmypixel opened this issue Nov 10, 2016 · 5 comments

Comments

@feedmypixel
Copy link
Contributor

feedmypixel commented Nov 10, 2016

Once we have the belts and braces of Visual Regression tests running on the component library there appears to be a lot of files and folders that are not in use inside assets-frontend.
This unused work can then be removed safely, with a level of confidence that it won't cause undesired knock on effects.

  • Work through the repository to find any files and folders that are not in use
  • Remove any files or folders that are not in use
@rpowis
Copy link
Contributor

rpowis commented Nov 10, 2016

Is this not a dupe of #376?

@feedmypixel
Copy link
Contributor Author

Is this not a dupe of #376?

no this is more a check everything and remove anything that is not being used issue. A tech debt tidy up. Which depending on its size may end up being split up.

@rpowis
Copy link
Contributor

rpowis commented Nov 10, 2016

This issue's very vague is all. We already have a deprecated issue label for stuff not covered in #376. Maybe we should link to all those in this issue instead?

@feedmypixel
Copy link
Contributor Author

feedmypixel commented Nov 10, 2016

This issue's very vague is all.

Good point, I have updated the description

deprecated issue label

In my mind this is associated with deprecated CSS and JavaScript from when the component library work was initially created

#376.

This is hard dependancies and potentially is deprecated itself if we are taking a component by component approach

@gordonmcmullan
Copy link
Contributor

Legacy stuff will be removed as part of the v4 work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants