-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoComplete does not handle non-uniques when typing #717
Comments
@automaticdreams Can you give an example gif? What's supposed to happen instead? |
I don't know what should happen This is edge case, so for example for Dominican republic, which has three possible title/value pairs and only when a user who does have javascript, chooses not to interact with the suggestion list, e.g. The requirement is that a user (when typing) only has to type the country, not the country code too. I don't have any suggestions about how to fix this |
Ah I see. This feels like a design issue then. It would be easier to just let the user type their country code rather than only being able to select it from a list no? |
yes, needs some design love..... |
Or should we reconsider whether an autocomplete is appropriate here at all, and just use the select....? |
Is there actually a use case where a user would type their country and then not interact with the suggestions? The purpose of the list is to choose a country code, not a country. I'd have thought the use cases for the list would be:
In both cases, they'd end up in the same position as someone who does know their country code. In which case they can either interact with the list to select the right one or type the code directly into a country code input. |
it's more a case that a user is able to type in and not interact with the suggestion list |
But that's the information we're ultimately trying to get out of them in this case isn't it? |
yes, I know.... |
If that's the case, I'm not sure this should be an issue raised against the autocomplete pattern (as yes, I'd suspect a
These, however, are process problems and ones we're trying to solve on a bigger scale than github issues affords |
a lot of this discussion is also in the original PR #714 |
If a user does not interact with the suggestion list, but simply types their entry, and there are multiple suggestions that match their typing, autoComplete defaults to the first matching option
The text was updated successfully, but these errors were encountered: