Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dl 13343 #325

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Dl 13343 #325

merged 4 commits into from
Mar 27, 2024

Conversation

Daveo-G
Copy link
Contributor

@Daveo-G Daveo-G commented Mar 27, 2024

!!! πŸ’‚β€β™‚οΈ PLEASE UPDATE THE TEXT BELOW AND REMOVE THIS LINE πŸ’‚β€β™‚οΈ !!!

Descriptive Title - including Jira story or Github issue number

Bug fix / New feature (delete as appropriate)

Please include a summary / description of the change and which issue it fixes. Include any relevant user needs and context.

Checklist

  • I've included appropriate tests with any code I've added
  • I've executed the acceptance test pack locally to ensure there are no regressions
  • I've added my code using logical, atomic commits, squashing as appropriate - including the Jira issue number in the commit message
  • I've run a dependency check to ensure all dependencies are up to date

@platops-pr-bot
Copy link

  • uk.gov.hmrc.sbt-auto-build can be updated to 3.20.0 in project/plugins.sbt
  • uk.gov.hmrc.sbt-artifactory can be removed in project/plugins.sbt along with all references to the plugin - It's available on build server
  • uk.gov.hmrc.sbt-bobby can be removed in project/plugins.sbt along with all references to the plugin - It's available on build server
  • Config key auditing.traceRequests can be removed from conf/application.conf. It has been unused since play-auditing:3.0.0
  • System property lookup can be removed in conf/application-json-logger.xml - Bootstrap's LoggerModule allows configuration of loggers without this - See confluence https://confluence.tools.tax.service.gov.uk/x/9oH1FQ
  • Deprecated config key application.router can be changed to play.http.router in conf/application.conf
  • Config key application.secret can be removed from conf/application.conf. This is already provided by Bootstrap
  • Deprecated config uk.gov.hmrc.play.bootstrap.AuditModule can be changed to uk.gov.hmrc.play.audit.AuditModule in conf/application.conf
  • Deprecated config uk.gov.hmrc.play.bootstrap.MicroserviceModule can be changed to uk.gov.hmrc.play.bootstrap.backend.BackendModule in conf/application.conf
  • Deprecated config uk.gov.hmrc.play.bootstrap.http.JsonErrorHandler can be changed to uk.gov.hmrc.play.bootstrap.backend.http.JsonErrorHandler in conf/application.conf
  • Config filter uk.gov.hmrc.play.bootstrap.filters.MicroserviceFilters can be removed from conf/application.conf. This is already provided by Bootstrap
  • There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details

@peckover peckover self-assigned this Mar 27, 2024
@peckover peckover merged commit 6736459 into main Mar 27, 2024
1 check passed
@peckover peckover deleted the DL-13343 branch March 27, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants