Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide version of govukFooter with Welsh translations #100

Closed
matthewmascord opened this issue Jun 23, 2020 · 2 comments
Closed

Provide version of govukFooter with Welsh translations #100

matthewmascord opened this issue Jun 23, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@matthewmascord
Copy link
Contributor

matthewmascord commented Jun 23, 2020

The govukFooter component (https://design-system.service.gov.uk/components/footer/) contains hard-coded English text for the copyright and licence statement. This issue has been referenced in issues:

alphagov/govuk-frontend#1290
alphagov/govuk-frontend#1291
alphagov/govuk-frontend#1682

These issues have not been moved since April 2019

In order for service teams to have a version of the footer supporting Welsh, and so teams do not end up copying and pasting the govukFooter, the hmrc design system should provide a clone of govukFooter, called hmrcFooter, which is identical and kept in step with the govukFooter component except for:

  • accepting a language parameter (with value en or cy)
  • render Welsh translations (if language == cy)
@matthewmascord matthewmascord added the bug Something isn't working label Jun 23, 2020
@timsb
Copy link
Contributor

timsb commented Oct 28, 2020

@matthewmascord Has this issue been resolved now that we've forked the footer in hmrc-frontend?

@matthewmascord
Copy link
Contributor Author

Component hmrcFooter now available in hmrc-frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants