Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header navigation text cannot be customised or translated #1682

Closed
36degrees opened this issue Dec 20, 2019 · 2 comments · Fixed by #1905
Closed

Header navigation text cannot be customised or translated #1682

36degrees opened this issue Dec 20, 2019 · 2 comments · Fixed by #1905
Assignees
@hannalaakso
Labels
header 🕔 hours A well understood issue which we expect to take less than a day to resolve. localisation nunjucks
Projects
Design System Sprint Board
Milestone
v3.9.0

Comments

@36degrees
Copy link
Contributor

36degrees commented Dec 20, 2019 •
edited by hannalaakso
Loading

The header contains hardcoded English strings in the template:

  • Show or hide Top Level Navigation
  • Menu
  • Top Level Navigation

govuk-frontend/src/govuk/components/header/template.njk

Line 63 in 584ea8d

<button type="button" class="govuk-header__menu-button govuk-js-header-toggle" aria-controls="navigation" aria-label="Show or hide Top Level Navigation">Menu</button>

govuk-frontend/src/govuk/components/header/template.njk

Line 65 in 584ea8d

<ul id="navigation" class="govuk-header__navigation {{ params.navigationClasses if params.navigationClasses }}" aria-label="Top Level Navigation">

This means this text cannot be customised or translated (for example into Welsh) whilst using the Nunjucks template.

Edit: split the customising of 'menu' into #1904
@36degrees 36degrees mentioned this issue Jan 10, 2020
Open
1 task
@kellylee-gds kellylee-gds added 🕔 hours A well understood issue which we expect to take less than a day to resolve. Priority: low labels Mar 5, 2020
@HughePaul
Copy link

Also in the footer, the visually hidden text "Support Links" and the copyright text, which would be "Mae’r holl gynnwys ar gael dan Drwydded y Llywodraeth Agored v3.0, ac eithrio lle nodir yn wahanol
© Hawlfraint y Goron" in Welsh

@matthewmascord matthewmascord mentioned this issue Jun 23, 2020
Closed
@hannalaakso hannalaakso added this to Upcoming sprints in Design System Sprint Board via automation Aug 3, 2020
@hannalaakso hannalaakso self-assigned this Aug 4, 2020
@hannalaakso hannalaakso moved this from Upcoming sprints to In progress in Design System Sprint Board Aug 4, 2020
@hannalaakso hannalaakso mentioned this issue Aug 4, 2020
Open
@hannalaakso
Copy link
Member

Thanks for the feedback @HughePaul 👍

the visually hidden text "Support Links"

I've left a comment to this effect on #1763.

the copyright text

This is covered by #1290.

This was referenced Aug 11, 2020
Closed
Merged
@hannalaakso hannalaakso moved this from In progress to Ready to release in Design System Sprint Board Aug 11, 2020
@hannalaakso hannalaakso moved this from Ready to release to Needs review in Design System Sprint Board Aug 12, 2020
@kellylee-gds kellylee-gds moved this from Needs review to Done in Design System Sprint Board Aug 13, 2020
@36degrees 36degrees moved this from Done to Ready to release in Design System Sprint Board Aug 13, 2020
@36degrees 36degrees added this to the [NEXT] milestone Sep 1, 2020
@hannalaakso hannalaakso moved this from Ready to release to Done in Design System Sprint Board Sep 14, 2020
@claireashworth claireashworth mentioned this issue Feb 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannalaakso hannalaakso

Labels
header 🕔 hours A well understood issue which we expect to take less than a day to resolve. localisation nunjucks
Projects
GOV.UK Design System cycle board
Archived in project
Design System Sprint Board
  
Done 🏁
Milestone
v3.9.0
4 participants
@36degrees @HughePaul @hannalaakso @kellylee-gds