Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLATUI-2590: Make a link or button print the page without having to write any custom javascript #325

Merged
merged 2 commits into from Nov 2, 2023

Conversation

kyle-bowden
Copy link
Contributor

No description provided.

@oscarduignan
Copy link
Contributor

in the component folder we could add a README.md that quickly explained why we have this component - I know that people can see the jira / github commit message but since jira's days are possibly numbered 🤷‍♂️ maybe something like

we've added this because a lot of services had implemented print links using inline javascript in html attributes that isn't compatible with some new default CSP security config that is recommended for HMRC services. Rather that everyone move the JS to different places / possibly introduce mistakes - this gives us something people can migrate to a bit more easily, and we now have people depending on an interface we can tweak later in one place in the remote chance we need

@kyle-bowden kyle-bowden force-pushed the PLATUI-2590_print_dialogue branch 5 times, most recently from 5626d64 to 6df5ad4 Compare November 2, 2023 13:41
CHANGELOG.md Outdated Show resolved Hide resolved
src/all.js Outdated Show resolved Hide resolved
oscarduignan
oscarduignan previously approved these changes Nov 2, 2023
Co-authored-by: Oscar Duignan <100650+oscarduignan@users.noreply.github.com>
@kyle-bowden kyle-bowden merged commit 83b25c6 into main Nov 2, 2023
1 check passed
@kyle-bowden kyle-bowden deleted the PLATUI-2590_print_dialogue branch November 2, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants