Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLATUI-2638 Enable Welsh language support for accessible-autocomplete #329

Merged
merged 10 commits into from
Nov 9, 2023
Merged

PLATUI-2638 Enable Welsh language support for accessible-autocomplete #329

merged 10 commits into from
Nov 9, 2023

Conversation

ellamdav
Copy link
Contributor

@ellamdav ellamdav commented Nov 6, 2023 •
edited

  • Pass Welsh language functions to accessible-autocomplete if data-language is set to cy
  • Updated README for the component to reflect current API and strip out irrelevant content

TimothyFothergill
TimothyFothergill previously approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@TimothyFothergill TimothyFothergill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oscarduignan
Copy link
Contributor

looks good to me, I guess the alternative would be the GDS convention of having translations provided to js stuff via data-i18n prefixed attributes data-i18n.assistive-hint="..." https://github.com/alphagov/govuk-frontend/blob/4d13a759e4ffdea97309fde322eeb82087ac6e23/packages/govuk-frontend/src/govuk/macros/i18n.njk#L17-L21 but then we wouldn't have any welsh translations out of the box in hmrc-frontend, they would have to be in play-frontend-hmrc

@ellamdav ellamdav force-pushed the PLATUI-2638-awtolenwi-hygyrch branch from 7f26805 to 272268f Compare November 9, 2023 11:33
@ellamdav ellamdav changed the title PLATUI-2638 POC PLATUI-2638 Enable Welsh language support for accessible-autocomplete Nov 9, 2023
@ellamdav ellamdav marked this pull request as ready for review November 9, 2023 12:08
@ellamdav ellamdav merged commit b7b0650 into main Nov 9, 2023
1 check passed
@ellamdav ellamdav deleted the PLATUI-2638-awtolenwi-hygyrch branch November 9, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscarduignan oscarduignan oscarduignan approved these changes

@TimothyFothergill TimothyFothergill TimothyFothergill left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ellamdav @oscarduignan @TimothyFothergill