PLATUI-2644: Hide when printing for language select and report techni… #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoPintoPaul
force-pushed
the
PLATUI-2644_display-none-print
branch
from
e3a805b
to
fa41f72
Compare
ellamdav
reviewed
Nov 20, 2023
| @@ -1,5 +1,5 @@ | |||
| {% if params.language === 'en' %} | |||
| <nav class="hmrc-language-select" aria-label="Language switcher"> | |||
| <nav class="hmrc-language-select govuk-!-display-none-print" aria-label="Language switcher"> | |||
There was a problem hiding this comment.
worth adding tests for these?
There was a problem hiding this comment.
@ellamdav Could do, could do... Seems like it's just checking the static template rather than any logic, but can add if that's what we think is best?
There was a problem hiding this comment.
It feels like double-entry coding in a way, but that's not such a bad thing - eg. someone could refactor the template to dry it up and this might get lost, but visually would still all look OK 🤷
ellamdav
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cal issue