PLATUI-2705: Upgrade to latest govuk-frontend v5.0.0 #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-bowden
force-pushed
the
PLATUI-2627_spike-govuk-frontend-5-0-0
branch
2 times, most recently
from
35d4ea5
to
52574ce
Compare
PLATUI-2627: Trying to fix JS import PLATUI-2627: Changed init of govuk-frontend JS
…ges in govuk-frontend
kyle-bowden
force-pushed
the
PLATUI-2627_spike-govuk-frontend-5-0-0
branch
from
52574ce
to
fd4d686
Compare
kyle-bowden
changed the title
kyle-bowden
force-pushed
the
PLATUI-2627_spike-govuk-frontend-5-0-0
branch
from
fd4d686
to
b3fe3ac
Compare
tasks/gulp/compile-js.js
Outdated
There was a problem hiding this comment.
probably lots of improvements we could snag from https://github.com/alphagov/govuk-frontend/blob/60b0a67bcd7cbb9c072c0fd573c30cdd5c2d31ba/packages/govuk-frontend/rollup.publish.config.mjs I think it's outside scope of this change probably - though maybe some bits we might want to do
kyle-bowden
force-pushed
the
PLATUI-2627_spike-govuk-frontend-5-0-0
branch
from
b3fe3ac
to
bced47f
Compare
JoPintoPaul
reviewed
Jan 15, 2024
| @@ -247,15 +247,6 @@ describe('header', () => { | |||
|
|
|||
| describe('SVG logo', () => { | |||
| const $ = render('header', {}); | |||
| const $svg = $('.govuk-header__logotype-crown'); | |||
|
|
|||
| it('sets focusable="false" so that IE does not treat it as an interactive element', () => { | |||
There was a problem hiding this comment.
This test has been deleted but it looks like we still have the SVG with focusable="false", should we keep the test? Or delete the attribute?
There was a problem hiding this comment.
I replaced the SVG element with the one from the guidance on the govuk-frontend release notes. I am going to leave the test that tests for focusable="false" as this is what govuk recommends.
kyle-bowden
force-pushed
the
PLATUI-2627_spike-govuk-frontend-5-0-0
branch
from
bced47f
to
6e55d21
Compare
JoPintoPaul
approved these changes
Jan 15, 2024
oscarduignan
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stuff that has happened in this PR