Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLATUI-441: Add currency input component from hmrc-frontend #17

Merged
merged 3 commits into from
May 11, 2020

Conversation

matthewmascord
Copy link
Contributor

@matthewmascord matthewmascord commented May 5, 2020

Allow additional set of test fixtures (in addition to those published within hmrc-frontend)

It is worth noting that this is the first time play-frontend-hmrc uses play-frontend-govuk. This is because hmrcCurrencyInput uses govukLabel and govukHint in the same way that the hmrc-frontend Nunjucks components do.

Copy link
Contributor

@nataliecarey nataliecarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this but should we hook in the new tests before releasing it?

@nataliecarey
Copy link
Contributor

Actually, the new tests won't add anything because the documentation for this isn't ready yet.

@matthewmascord matthewmascord merged commit 8717d4e into master May 11, 2020
@matthewmascord matthewmascord deleted the PLATUI-441-add-currency-input branch May 11, 2020 16:25
matthewmascord pushed a commit that referenced this pull request Aug 18, 2021
PLATUI-168: Increase test coverage for backLink and checkboxes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants