PLATUI-2897 enable passing of attributes to input form group wrappers

[ellamdav]

• add new FormGroup model
• uplift the following inputs to add attributes to govuk-form-group:
  ** GovukCharacterCount
  ** GovukCheckboxes
  ** GovukDateInput
  ** GovukFileUpload
  ** GovukInput
  ** GovukRadios
  ** GovukSelect
  ** GovukTextarea
  ** HmrcCharacterCount
• extract GovukFormGroupSnippet to de-duplicate repeated code across inputs
• extract GovukHintAndErrorMessageSnippet to de-duplicate existing hint/error-message snippets repeated across inputs

[ellamdav]

just to remind people (like me 😅) who see the deprecation warning that we can't do this just yet 🙃

[ellamdav]

noticed values was missing here 🙃

[JoPintoPaul]

Out of interest, I notice a pattern of using fold on options, passing through the default as the first param list - was that just a matter of taste or is there nuance I'm missing there?

[JoPintoPaul]

Also, one more comment from me - as a thought on using snippets to compose HTML templates, one thing to consider is that manually syncing with govuk-frontend templates will therefore require switching between files to compare. Obviously that's balanced against repetition / DRY, I just wanted to point out the risks with this divergence.

[ellamdav]

Out of interest, I notice a pattern of using fold on options, passing through the default as the first param list - was that just a matter of taste or is there nuance I'm missing there?

TBH I just went with what was already there, but could change to .map(...).getOrElse(...) if we think that's easier to grok?

[oscarduignan]

some of the composition of stuff in twirl components is so hard to follow 😵

this isn't me saying do this, just me taking a moment to think if I could imagine the a flavour I might like, this kind of structure was my first thought

@(checkboxes: Checkbox)

@govukFormGroup(checkboxes.formGroup) {
  @govukFieldset(checkboxes.fieldset) { 
    @govukHint(checkboxes.hint)
    @govukErrorMessage(checkboxes.errorMessage)
    ... inputs
  }
})

[ellamdav]

Agreed - the issue seems to be accumulating the right aria-describedby when there's maybe a supplied one, maybe one related to the hint, and maybe one related to the error message... But perhaps there's a nicer way to do it, like using cats State or something 😅