This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Assets download fix for running from profiles #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a little concerned that this change is a little bit too HMRC specific. now that this code is open source we need to think about whether changes are valuable to all users... hardcoding a specific implementation of assets may regress the usefulness of the codebase as an open source project Is it possible to handle assets in more generic way? Note: This may require some refactoring of the existing codebase... |
| @@ -95,6 +97,10 @@ def start_from_binary(self): | |||
| parent, _ = os.path.split(unzip_dir) | |||
| force_pushdir(parent) | |||
|
|
|||
| if "frontend" in self.service_data and self.service_data["frontend"]: | |||
There was a problem hiding this comment.
could we rename this to be "is_frontend", you can also do "if self.service_data.get("is_frontend", False):"
|
Valid points for refactoring but as we need to get this fix rolled out we'll make these changes in the next iteration. |
SteveSmithTech
pushed a commit
that referenced
this pull request
May 11, 2015
Assets download fix for running from profiles
SteveSmithTech
pushed a commit
that referenced
this pull request
Sep 14, 2015
Assets download fix for running from profiles
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.