-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set_size.show #104
set_size.show #104
Conversation
Merge branch 'master' of https://github.com/jonocarroll/UpSetR
…no Rnotebook output
Hi, Is this feature available? Thanks. |
Hi @JianWang2016 it does not appear to be available in the main branch as of yet, however, you can use my version of this package to get it if you would like - to do this I would recommend cloning my version locally and using R's Download the repo from: https://github.com/RichardJActon/UpSetR and run this R code before the rest of your work:
Then you should have access to this feature. |
Thanks much. I will give it a try tomorrow. |
I just tried the set_size.show = TRUE feature. It does show the number within the side bars if used in R console. However, when this version is used in R shiny, the entire image is not drawn anymore. The cran version of UpSet.R works with R shiny. The only change is 1) upgrade to github master UpSet.R. The image can't be drawn with set_size.show = TRUE neither set_size.show = FALSE. The code works immediately when switching back to cran version. I am yet to investigate what is causing it incompatible with R shiny. At meanwhile I would greatly appreciate if you have any insight. |
All working out well here, maybe another enhancement to this would be to set where horizontally these numbers are plotted. In my case, I could do with having them a bit more to the left (see below) so they wouldn't sit on top of the bar. |
Hi @GeoMicroSoares, yes I think it would be just |
@RichardJActon that would be ideal actually! Thanks so much for your work btw, love the package! |
@RichardJActon Any updates on this? The CRAN version is cutting off the labels on the left and I can't figure out how to fix it. [EDIT] For those who are as dense as me, if you increase the max size of the plot with the |
A fix for issue #74
Adds the
set_size.show
parameter to upset which adds ageom_text
element toSize_plot
if set to TRUE.Text scales with the axis labels and is positioned such that it should be ~aligned with the leftmost end of the bars.