Added support for Java Based Config #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear All Could you please look into this merge request? @bflad @boneill42 @ptgoetz @tranhuong Thanks Peter |
|
Seems reasonable and compiles for me. What do you think @DeanPoulin / @irieksts? Only nitpick I have is the RuntimeException is not informative. |
|
Any reason why this isn't merged yet? And not just this. There are a few other PRs just waiting in the wings, some for over a year it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Team
I added Java Based Config support to this project. Additionally made minor code cleanup and readme.md cleanup.
It might be a legacy naming, but SpringService should be renamed to SpringApplication, but I didn't want to do that as it might be a breaking change.
Hope you will like it.