Support WebApplicationContext. #7
Conversation
|
|
||
| import java.util.Map; | ||
|
|
||
| public class FilterConfiguration { |
There was a problem hiding this comment.
Why do we need a Configuration object for servlet filters? Can't they just be bean references like all the other dropwizard components?
There was a problem hiding this comment.
We can use bean references and add through this method addFilter(Filter filter, String urlPattern). In order to get urlPattern, I think, we should have DropwizardFilter interfact that is extended from javax.servle.Filter and provide getUrlPattern method. Then, all Filter bean will implement DropwizardFilter interface. How do you think?
There was a problem hiding this comment.
The main reason, I can't use bean references, because DelegatingFilterProxy requires ServletContext to initiate.
|
Can we update the README.md with documentation concerning what this does and how to use it? |
|
I updated README.md to reflect the changes |
|
+1 |
Support WebApplicationContext.
No description provided.