-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vol command improvements #45
vol command improvements #45
Conversation
That same as #44, could you update the |
b8b804d
to
c59734e
Compare
As a side note, now that
this is technically an API breaking change. I don't know if you follow semver or anything but when this is merged it would be classified as a major version. |
…wn' and echo's new volume level when setting to a specific volume level Added more helpful text for improper vol option
c59734e
to
76df385
Compare
@@ -58,7 +58,6 @@ spotify share Shows and copies the current song URL to the c | |||
|
|||
spotify toggle shuffle Toggles shuffle playback mode. | |||
spotify toggle repeat Toggles repeat playback mode. | |||
```` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line appears to be removed by accident.
76df385
to
c37a9f7
Compare
current volume level. The docs have been updated to reflect this change.
Added check that volume argument is a number if it is not 'up' or 'down' and echo's new volume level when setting to a specific volume level
Added more helpful text for improper vol option