Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vol command improvements #45

Merged
merged 5 commits into from
Sep 18, 2016

Conversation

ericmarkmartin
Copy link
Contributor

Added check that volume argument is a number if it is not 'up' or 'down' and echo's new volume level when setting to a specific volume level

Added more helpful text for improper vol option

@ericmarkmartin ericmarkmartin changed the title vol command improvements vol command improvements Aug 24, 2016
@tpritc
Copy link

tpritc commented Aug 24, 2016

That same as #44, could you update the vol show command to just be vol in your help text? Thanks.

@ericmarkmartin ericmarkmartin mentioned this pull request Aug 31, 2016
@ericmarkmartin ericmarkmartin force-pushed the wip/vol-improvement branch 5 times, most recently from b8b804d to c59734e Compare August 31, 2016 04:11
@ericmarkmartin
Copy link
Contributor Author

As a side note, now that spotify vol show no longer shows the volume:

$ spotify vol show
Improper use of `vol` command
The `vol` command should be used as follows:
  vol up                       # Increases the volume by 10%.
  vol down                     # Decreases the volume by 10%.
  vol [amount]                 # Sets the volume to an amount between 0 and 100.
  vol                          # Shows the current Spotify volume.

this is technically an API breaking change. I don't know if you follow semver or anything but when this is merged it would be classified as a major version.

@ericmarkmartin ericmarkmartin deleted the wip/vol-improvement branch September 3, 2016 04:55
@ericmarkmartin ericmarkmartin restored the wip/vol-improvement branch September 3, 2016 04:55
@ericmarkmartin ericmarkmartin reopened this Sep 3, 2016
…wn' and echo's new volume level when setting to a specific volume level

Added more helpful text for improper vol option
@@ -58,7 +58,6 @@ spotify share Shows and copies the current song URL to the c

spotify toggle shuffle Toggles shuffle playback mode.
spotify toggle repeat Toggles repeat playback mode.
````
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line appears to be removed by accident.

@hnarayanan hnarayanan merged commit 3674c1c into hnarayanan:master Sep 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants