-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chat.getPermalink #279
chat.getPermalink #279
Conversation
|
||
@JacksonDataClass | ||
data class ChatGetPermalinkRequest constructor(@JsonProperty("channel") val channel: String, | ||
@JsonProperty("message_ts") val timestamp: Instant) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after my PR you need the @InstantToString annotation here
|
||
@JacksonDataClass | ||
data class SuccessfulChatGetPermalinkResponse constructor(override val ok: Boolean, | ||
@JsonProperty("channel") val channel: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the property should be named channelId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can you upgrade the version to M4 for this one
What problem are you trying to solve or corresponding Issue
added missing implementation of chat.getPermalink
Current Behavior
missing implementation