Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean temporary files #11

Closed
bertsky opened this issue Oct 15, 2020 · 3 comments
Closed

clean temporary files #11

bertsky opened this issue Oct 15, 2020 · 3 comments

Comments

@bertsky
Copy link
Contributor

bertsky commented Oct 15, 2020

ocrd_browser needs to store preview images in the OS' temporary files location. This can easily sum up to a few gigabytes for large workspaces.

IMHO it would be better to remove these files when closing (even if they could be re-used) to prevent partitions (or RAM disks) from filling up.

@bertsky
Copy link
Contributor Author

bertsky commented Oct 16, 2020

Correcting myself: not preview images, but the cloning of the workspace is the problem here.

I see 2 drawbacks:

  • extra storage requirements (esp. when not cleaned up afterwards; but how do you know this can be safely removed at on_close time?)
  • not all workspaces can be fully downloaded successfully (local file references might be wrong, or remote references temporarily unresolvable)

But I see that certain parts of the UI already allow modifying the workspace (like reorder immediately doing save_mets). What's the point in having a save_as then? 😕

@hnesk
Copy link
Owner

hnesk commented Oct 18, 2020

You are onto something there, I tried to fix this mess in #16. Needs some testing and thinking still...

@hnesk
Copy link
Owner

hnesk commented Oct 22, 2020

Now merged #16, should fix the unnecessary clones and empty workspaces.
If there are problems with loading/cloning of concrete workspaces feel free to open an issue for that.

@hnesk hnesk closed this as completed Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants