Workspaces are read-only by default, introduce "Edit Mode" #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In the image view, instead of a fixed number of images (one for each page) configured in a horizontal box, show a fixed number of vertical boxes (one for each page) with a variable number of images (one for each image file of that pageId in the fileGrp, i.e. AlternativeImage). - Re-use both VBox widgets (when reconfiguring page multiplier) and Image widgets (when changing to another page_id). - If there are no image files, extract the current page image (as before). - Keep the file references along with open images, and search the PAGE-XML for the respective AlternativeImage segments. Show their ID as tooltip, or fall back to the image file path.
- separate redrawing image widgets when config/page changed drom rescaling images - add configurator widget for zoom level (log scale) - track mouse wheel events, pass ctrl+wheel to scale - fix image tooltip calculation for page_from_image case
Introduced Document._editable and @check_editable decorator Avoided clones when not _editable Cleanup ate exit after clones
Closed
…/browse-ocrd into bertsky-multiple-images-per-page
|
Currently testing this on a METS with unresolvable remote fileGrps. Now that |
Introduced Document._editable and @check_editable decorator Avoided clones when not _editable Cleanup ate exit after clones
|
workspace_from_nothing() is not used any more |
|
Fantastic – many thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Document class allows to modify a workspace in place. To mitigate accidental changes, before this PR all workspaces where cloned to a temporary directory when opening a workspace.
This PR introduces an "Edit Mode". When a workspace gets opened the workspace is displayed as-is in the current workspace location (via Document.load()). All editing capabilities are disabled, also saving.
By enabling "Edit Mode" the workspace gets cloned (Document.clone()) to a temporary workspace and all workspace editing actions and saving are enabled. Saving means cloning back to the original location. At exit all temporary workspaces are deleted. If there are unsaved changes, a confirmation dialog is shown, like the user is expecting from other applications
Solves: